Fixes a couple of bugs in NativeWidgetMus

Fixes a couple of bugs in NativeWidgetMus

1. Show state was not getting configured correctly.
2. If a ui::WindowObserver was added before NativeWidgetMus, and that
   ui::WindowObserver queried show state from the widget it could get
   the wrong results. I'm hoping the change is enough, I may need to
   introduce a pre-change that NativeWidgetMus uses. We'll see.
3. Changed looking at surface_type to an explicit function
   is_parallel_widget_in_window_manager().

I added a test for 2, which is the more subtle of the fixes.

BUG=634972
TEST=mostly covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/039443070732a60fbdac74929cfbefc627c565d9
Cr-Commit-Position: refs/heads/master@{#410460}

[sky, 2016-08-08 18:29:16]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 18:29:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 19:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:38:48]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-08 20:31:22]

lgtm

https://codereview.chromium.org/2225833003/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/2225833003/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:1427: if
(is_parallel_widget_in_window_manager())
SWould it make sense to override these from WmNativeWidgetMus to be no-ops
instead?

[sky, 2016-08-08 21:10:44]

https://codereview.chromium.org/2225833003/diff/20001/ui/views/mus/native_wid...
File ui/views/mus/native_widget_mus.cc (right):

https://codereview.chromium.org/2225833003/diff/20001/ui/views/mus/native_wid...
ui/views/mus/native_widget_mus.cc:1427: if
(is_parallel_widget_in_window_manager())
On 2016/08/08 20:31:21, sadrul wrote:
> SWould it make sense to override these from WmNativeWidgetMus to be no-ops
> instead?

I have certainly done that, but it's very subtle and easy to miss. I though it
would be less mysterious to have the code here.

[sky, 2016-08-08 21:10:48]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-08 21:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:15:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 21:18:31]

Description was changed from

==========
Fixes a couple of bugs in NativeWidgetMus

1. Show state was not getting configured correctly.
2. If a ui::WindowObserver was added before NativeWidgetMus, and that
   ui::WindowObserver queried show state from the widget it could get
   the wrong results. I'm hoping the change is enough, I may need to
   introduce a pre-change that NativeWidgetMus uses. We'll see.
3. Changed looking at surface_type to an explicit function
   is_parallel_widget_in_window_manager().

I added a test for 2, which is the more subtle of the fixes.

BUG=634972
TEST=mostly covered by tests
R=sadrul@chromium.org
==========

to

==========
Fixes a couple of bugs in NativeWidgetMus

1. Show state was not getting configured correctly.
2. If a ui::WindowObserver was added before NativeWidgetMus, and that
   ui::WindowObserver queried show state from the widget it could get
   the wrong results. I'm hoping the change is enough, I may need to
   introduce a pre-change that NativeWidgetMus uses. We'll see.
3. Changed looking at surface_type to an explicit function
   is_parallel_widget_in_window_manager().

I added a test for 2, which is the more subtle of the fixes.

BUG=634972
TEST=mostly covered by tests
R=sadrul@chromium.org

Committed: https://crrev.com/039443070732a60fbdac74929cfbefc627c565d9
Cr-Commit-Position: refs/heads/master@{#410460}
==========

[commit-bot: I haz the power, 2016-08-08 21:18:32]

Patchset 2 (id:??) landed as
https://crrev.com/039443070732a60fbdac74929cfbefc627c565d9
Cr-Commit-Position: refs/heads/master@{#410460}