Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2225763002: Fix percent encoding to not encode digits. (Closed)

Created:
4 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 4 months ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/convert@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix percent encoding to not encode digits.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/percent/encoder.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
4 years, 4 months ago (2016-08-08 07:39:20 UTC) #2
floitsch
No new tests?
4 years, 4 months ago (2016-08-08 15:04:55 UTC) #3
nweiz
I merged an external CL that did the same thing, so I think this can ...
4 years, 4 months ago (2016-08-08 22:17:11 UTC) #4
Lasse Reichstein Nielsen
On 2016/08/08 22:17:11, nweiz wrote: > I merged an external CL that did the same ...
4 years, 4 months ago (2016-08-09 07:30:24 UTC) #5
Lasse Reichstein Nielsen
4 years, 4 months ago (2016-08-09 07:42:47 UTC) #6
On 2016/08/09 07:30:24, Lasse Reichstein Nielsen wrote:
> Did you add a version update and republish?

Silly question, I can check that myself, and yes you did. Thanks :)

Powered by Google App Engine
This is Rietveld 408576698