Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2225733002: Revert of Move ThreadableLoader to Oilpan heap (3/3) (Closed)

Created:
4 years, 4 months ago by yhirano
Modified:
4 years, 4 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@onheap-threadable-loader
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ThreadableLoader to Oilpan heap (3/3) (patchset #5 id:80001 of https://codereview.chromium.org/2193683004/ ) Reason for revert: To investigate crashes reported at https://crbug.com/634546. Original issue's description: > Move ThreadableLoader to Oilpan heap (3/3) > > This CL is a refactoring and does not change the behavior. > > BUG=587663 > > Committed: https://crrev.com/2ec047e0061d6c07339e404f918f34459ab6a7b8 > Cr-Commit-Position: refs/heads/master@{#409961} TBR=haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=587663 Committed: https://crrev.com/fc0e0664d4b347c5757b557e4838a070f801089e Cr-Commit-Position: refs/heads/master@{#410312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -82 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h View 2 chunks +24 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h View 6 chunks +10 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 23 chunks +46 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yhirano
Created Revert of Move ThreadableLoader to Oilpan heap (3/3)
4 years, 4 months ago (2016-08-08 04:59:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225733002/1
4 years, 4 months ago (2016-08-08 04:59:47 UTC) #3
haraken
LGTM
4 years, 4 months ago (2016-08-08 05:04:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 07:18:06 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 07:19:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc0e0664d4b347c5757b557e4838a070f801089e
Cr-Commit-Position: refs/heads/master@{#410312}

Powered by Google App Engine
This is Rietveld 408576698