Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 222573002: cc: Add CHECKs that the backing size reported by canvas matches. (Closed)

Created:
6 years, 8 months ago by danakj
Modified:
6 years, 8 months ago
Reviewers:
reveman, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman
Visibility:
Public.

Description

cc: Add CHECKs that the backing size reported by canvas matches. After making the canvas, ensure the size it reports is correct. Also pass the full content_rect to ContentLayerUpdater::PaintContents instead of deriving the size from the canvas, and double-check the size matches the canvas there. R=reveman@chromium.org BUG=358470 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261526

Patch Set 1 : contentupdatercrash: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M cc/resources/bitmap_content_layer_updater.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/resources/content_layer_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/content_layer_updater.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M cc/resources/skpicture_content_layer_updater.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
danakj
6 years, 8 months ago (2014-04-02 17:34:21 UTC) #1
enne (OOO)
landmines lgtm
6 years, 8 months ago (2014-04-02 17:37:50 UTC) #2
reveman
lgtm
6 years, 8 months ago (2014-04-02 17:42:27 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 8 months ago (2014-04-03 17:06:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/222573002/1
6 years, 8 months ago (2014-04-03 17:06:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 20:50:56 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 20:50:56 UTC) #7
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 8 months ago (2014-04-03 21:00:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/222573002/1
6 years, 8 months ago (2014-04-03 21:02:47 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 21:05:33 UTC) #10
Message was sent while issue was closed.
Change committed as 261526

Powered by Google App Engine
This is Rietveld 408576698