Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: cc/resources/content_layer_updater.cc

Issue 222573002: cc: Add CHECKs that the backing size reported by canvas matches. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: contentupdatercrash: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/resources/content_layer_updater.h ('k') | cc/resources/skpicture_content_layer_updater.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/content_layer_updater.h" 5 #include "cc/resources/content_layer_updater.h"
6 6
7 #include "base/debug/trace_event.h" 7 #include "base/debug/trace_event.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "cc/debug/rendering_stats_instrumentation.h" 9 #include "cc/debug/rendering_stats_instrumentation.h"
10 #include "cc/resources/layer_painter.h" 10 #include "cc/resources/layer_painter.h"
(...skipping 17 matching lines...) Expand all
28 painter_(painter.Pass()) {} 28 painter_(painter.Pass()) {}
29 29
30 ContentLayerUpdater::~ContentLayerUpdater() {} 30 ContentLayerUpdater::~ContentLayerUpdater() {}
31 31
32 void ContentLayerUpdater::set_rendering_stats_instrumentation( 32 void ContentLayerUpdater::set_rendering_stats_instrumentation(
33 RenderingStatsInstrumentation* rsi) { 33 RenderingStatsInstrumentation* rsi) {
34 rendering_stats_instrumentation_ = rsi; 34 rendering_stats_instrumentation_ = rsi;
35 } 35 }
36 36
37 void ContentLayerUpdater::PaintContents(SkCanvas* canvas, 37 void ContentLayerUpdater::PaintContents(SkCanvas* canvas,
38 const gfx::Point& origin, 38 const gfx::Rect& content_rect,
39 float contents_width_scale, 39 float contents_width_scale,
40 float contents_height_scale, 40 float contents_height_scale,
41 gfx::Rect* resulting_opaque_rect) { 41 gfx::Rect* resulting_opaque_rect) {
42 TRACE_EVENT0("cc", "ContentLayerUpdater::PaintContents"); 42 TRACE_EVENT0("cc", "ContentLayerUpdater::PaintContents");
43 canvas->save(); 43 canvas->save();
44 canvas->translate(SkFloatToScalar(-origin.x()), 44 canvas->translate(SkFloatToScalar(-content_rect.x()),
45 SkFloatToScalar(-origin.y())); 45 SkFloatToScalar(-content_rect.y()));
46 46
47 SkISize size = canvas->getDeviceSize(); 47 // The |canvas| backing should be sized to hold the |content_rect|.
48 gfx::Rect content_rect(origin, gfx::Size(size.width(), size.height())); 48 SkISize size = canvas->getBaseLayerSize();
49 CHECK_EQ(content_rect.width(), size.width());
50 CHECK_EQ(content_rect.height(), size.height());
49 51
50 gfx::Rect layer_rect = content_rect; 52 gfx::Rect layer_rect = content_rect;
51
52 if (contents_width_scale != 1.f || contents_height_scale != 1.f) { 53 if (contents_width_scale != 1.f || contents_height_scale != 1.f) {
53 canvas->scale(SkFloatToScalar(contents_width_scale), 54 canvas->scale(SkFloatToScalar(contents_width_scale),
54 SkFloatToScalar(contents_height_scale)); 55 SkFloatToScalar(contents_height_scale));
55 56
56 layer_rect = gfx::ScaleToEnclosingRect( 57 layer_rect = gfx::ScaleToEnclosingRect(
57 content_rect, 1.f / contents_width_scale, 1.f / contents_height_scale); 58 content_rect, 1.f / contents_width_scale, 1.f / contents_height_scale);
58 } 59 }
59 60
60 SkRect layer_sk_rect = SkRect::MakeXYWH( 61 SkRect layer_sk_rect = SkRect::MakeXYWH(
61 layer_rect.x(), layer_rect.y(), layer_rect.width(), layer_rect.height()); 62 layer_rect.x(), layer_rect.y(), layer_rect.width(), layer_rect.height());
(...skipping 20 matching lines...) Expand all
82 83
83 void ContentLayerUpdater::SetOpaque(bool opaque) { 84 void ContentLayerUpdater::SetOpaque(bool opaque) {
84 layer_is_opaque_ = opaque; 85 layer_is_opaque_ = opaque;
85 } 86 }
86 87
87 void ContentLayerUpdater::SetFillsBoundsCompletely(bool fills_bounds) { 88 void ContentLayerUpdater::SetFillsBoundsCompletely(bool fills_bounds) {
88 layer_fills_bounds_completely_ = fills_bounds; 89 layer_fills_bounds_completely_ = fills_bounds;
89 } 90 }
90 91
91 } // namespace cc 92 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/content_layer_updater.h ('k') | cc/resources/skpicture_content_layer_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698