Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: src/compiler/operator.h

Issue 2225683009: [turbolizer] Show operator properties and arity in tooltip. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@t-base
Patch Set: OP_PROP_LIST -> OPERATOR_PROPERTY_LIST Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/graph-visualizer.cc ('k') | src/compiler/operator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/operator.h
diff --git a/src/compiler/operator.h b/src/compiler/operator.h
index d8f19bfdeb8fef10bc57fddadb4ee3c0358870a7..b6ec2c618ca582d6dc0465888a89ebe71ee896b3 100644
--- a/src/compiler/operator.h
+++ b/src/compiler/operator.h
@@ -49,6 +49,12 @@ class Operator : public ZoneObject {
kEliminatable = kNoDeopt | kNoWrite | kNoThrow,
kPure = kNoDeopt | kNoRead | kNoWrite | kNoThrow | kIdempotent
};
+
+// List of all bits, for the visualizer.
+#define OPERATOR_PROPERTY_LIST(V) \
+ V(Commutative) \
+ V(Associative) V(Idempotent) V(NoRead) V(NoWrite) V(NoThrow) V(NoDeopt)
+
typedef base::Flags<Property, uint8_t> Properties;
enum class PrintVerbosity { kVerbose, kSilent };
@@ -122,6 +128,8 @@ class Operator : public ZoneObject {
return PrintToImpl(os, verbose);
}
+ void PrintPropsTo(std::ostream& os) const;
+
protected:
virtual void PrintToImpl(std::ostream& os, PrintVerbosity verbose) const;
« no previous file with comments | « src/compiler/graph-visualizer.cc ('k') | src/compiler/operator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698