[SVGDom] Improve whitespace handling in style parsing

[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225623002

Committed: https://skia.googlesource.com/skia/+/61f36b37084e7b1c80cfc485825588604a401c9a

[f(malita), 2016-08-07 02:42:15]

Description was changed from

==========
[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
==========

to

==========
[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225623002
==========

[f(malita), 2016-08-07 02:44:34]

Description was changed from

==========
[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225623002
==========

to

==========
[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225623002
==========

[f(malita), 2016-08-07 02:44:48]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 02:44:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-07 02:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-07 02:53:41]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[robertphillips, 2016-08-08 12:39:30]

lgtm. Do we need the *.orig file?

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGAttributeParser.cpp (right):

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGAttributeParser.cpp:165: 
Do we need to init 'color' to something in case the string is all white space?

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGDOM.cpp (right):

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGDOM.cpp:147: 
Does this need to be class-scoped? It seems like this would be more generally
useful.

[f(malita), 2016-08-08 13:00:02]

On 2016/08/08 12:39:30, robertphillips wrote:
> Do we need the *.orig file?

Doh.  Wildcard git add :)

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGAttributeParser.cpp (right):

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGAttributeParser.cpp:165: 
On 2016/08/08 12:39:30, robertphillips wrote:
> Do we need to init 'color' to something in case the string is all white space?

All SVG types have default constructors, so color is already default-initialized
by the caller (an unfortunate side-effect of the current out-param parser API;
maybe we can refactor to avoid?).  Good point about empty string parsing though,
we should not return success in that case.

Done.

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGDOM.cpp (right):

https://codereview.chromium.org/2225623002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGDOM.cpp:147: 
On 2016/08/08 12:39:30, robertphillips wrote:
> Does this need to be class-scoped? It seems like this would be more generally
> useful.

Done/moved out of the class.

[f(malita), 2016-08-08 13:00:07]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 13:00:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 13:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 13:28:18]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-08-08 20:08:34]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-08 20:08:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2225623002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-08 20:08:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:58:53]

Description was changed from

==========
[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225623002
==========

to

==========
[SVGDom] Improve whitespace handling in style parsing

Handle whitespace-padded style names/values.

R=stephana@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225623002

Committed:
https://skia.googlesource.com/skia/+/61f36b37084e7b1c80cfc485825588604a401c9a
==========

[commit-bot: I haz the power, 2016-08-08 20:58:54]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/61f36b37084e7b1c80cfc485825588604a401c9a