Don't treat trust anchors as certificates during path building.

components/cast_certificate/cast_cert_validator.cc

Index: components/cast_certificate/cast_cert_validator.cc
diff --git a/components/cast_certificate/cast_cert_validator.cc b/components/cast_certificate/cast_cert_validator.cc
index 9dcff2fe63f99412671f756366a8591e34027614..f022fc6001548904669f9280574fec4ee998e7f6 100644
--- a/components/cast_certificate/cast_cert_validator.cc
+++ b/components/cast_certificate/cast_cert_validator.cc
@@ -67,12 +67,15 @@ class CastTrustStore {
   // storage.
   template <size_t N>
   void AddAnchor(const uint8_t (&data)[N]) {
-    scoped_refptr<net::ParsedCertificate> root =
+    scoped_refptr<net::ParsedCertificate> cert =
         net::ParsedCertificate::CreateFromCertificateData(
             data, N, net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE,
             {});
-    CHECK(root);
-    store_.AddTrustedCertificate(std::move(root));
+    CHECK(cert);
+    // TODO(crbug.com/635200): Support anchor constraints.
+    auto anchor =

[mattm, 2016/08/09 00:59:21]

I think using auto for these Foo::Create calls don't meet the style guide
recommendation of only using it when the type is obvious. (See also various
chromium-dev threads about auto and smart pointers)

[eroman, 2016/08/09 01:37:20]

Done.

[mattm, 2016/08/09 19:51:04]

There are a few in other files too (cast_crl.cc, cast_crl_unittest.cc,
path_builder_pkits_unittest.cc, path_builder_unittest.cc,
verify_certificate_chain_pkits_unittest.cc)

[eroman, 2016/08/09 23:42:07]

Done.

+        net::TrustAnchor::CreateFromCertificateNoConstraints(std::move(cert));
+    store_.AddTrustAnchor(std::move(anchor));
   }
 
   net::TrustStore store_;