Don't treat trust anchors as certificates during path building.

components/cast_certificate/cast_cert_validator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cast_certificate/cast_cert_validator.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 49 matching lines @@
 
   CastTrustStore() {
     AddAnchor(kCastRootCaDer);
     AddAnchor(kEurekaRootCaDer);
   }
 
   // Adds a trust anchor given a DER-encoded certificate from static
   // storage.
   template <size_t N>
   void AddAnchor(const uint8_t (&data)[N]) {
-    scoped_refptr<net::ParsedCertificate> root =
+    scoped_refptr<net::ParsedCertificate> cert =
         net::ParsedCertificate::CreateFromCertificateData(
             data, N, net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE,
             {});
-    CHECK(root);
-    store_.AddTrustedCertificate(std::move(root));
+    CHECK(cert);
+    // TODO(crbug.com/635200): Support anchor constraints.
+    auto anchor =

[mattm, 2016/08/09 00:59:21]

I think using auto for these Foo::Create calls don't meet the style guide
recommendation of only using it when the type is obvious. (See also various
chromium-dev threads about auto and smart pointers)

[eroman, 2016/08/09 01:37:20]

Done.

[mattm, 2016/08/09 19:51:04]

There are a few in other files too (cast_crl.cc, cast_crl_unittest.cc,
path_builder_pkits_unittest.cc, path_builder_unittest.cc,
verify_certificate_chain_pkits_unittest.cc)

[eroman, 2016/08/09 23:42:07]

Done.

+        net::TrustAnchor::CreateFromCertificateNoConstraints(std::move(cert));
+    store_.AddTrustAnchor(std::move(anchor));
   }
 
   net::TrustStore store_;
   DISALLOW_COPY_AND_ASSIGN(CastTrustStore);
 };
 
 using ExtensionsMap = std::map<net::der::Input, net::ParsedExtension>;
 
 // Helper that looks up an extension by OID given a map of extensions.
 bool GetExtensionValue(const ExtensionsMap& extensions,
@@ skipping 261 matching lines @@
 
 std::unique_ptr<CertVerificationContext> CertVerificationContextImplForTest(
     const base::StringPiece& spki) {
   // Use a bogus CommonName, since this is just exposed for testing signature
   // verification by unittests.
   return base::WrapUnique(
       new CertVerificationContextImpl(net::der::Input(spki), "CommonName"));
 }
 
 }  // namespace cast_certificate