net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py - Issue 2225493003: Don't treat trust anchors as certificates during path building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py

Issue 2225493003: Don't treat trust anchors as certificates during path building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address moar feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/generate-expired-root.py ('k') | net/data/verify_certificate_chain_unittest/violates-pathlen-1-root.pem » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py b/net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py

index 149c000cff6b4dfe826327e3459a5ccb8c0c0565..b762d594b75d3921732bbf22b7ee535a35eb67f2 100755

--- a/net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py

+++ b/net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py

@@ -4,7 +4,8 @@

# found in the LICENSE file.

"""Certificate chain with 2 intermediates and one end entity certificate. The

-root certificate has a pathlen:1 restriction so this is an invalid chain."""

+root certificate has a pathlen:1 restriction. Ordinarily this would be an

+invalid chain, however constraints on trust anchors are not validated."""

import common

@@ -26,6 +27,6 @@ target = common.create_end_entity_certificate('Target', intermediate2)

chain = [target, intermediate2, intermediate1]

trusted = [root]

time = common.DEFAULT_TIME

-verify_result = False

+verify_result = True

common.write_test_file(__doc__, chain, trusted, time, verify_result)