net/data/verify_certificate_chain_unittest/generate-expired-root.py - Issue 2225493003: Don't treat trust anchors as certificates during path building.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-expired-root.py

Issue 2225493003: Don't treat trust anchors as certificates during path building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address moar feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/expired-root.pem ('k') | net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-expired-root.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-expired-root.py b/net/data/verify_certificate_chain_unittest/generate-expired-root.py

index 328edccbcdb8ec2f8502ddd7e432e026ce5b084e..ff086571bff81ae76a6dc97084381a965a681bf7 100755

--- a/net/data/verify_certificate_chain_unittest/generate-expired-root.py

+++ b/net/data/verify_certificate_chain_unittest/generate-expired-root.py

@@ -4,7 +4,8 @@

# found in the LICENSE file.

"""Certificate chain with 1 intermediate, where the root certificate is expired

-(violates validity.notAfter). Verification is expected to fail."""

+(violates validity.notAfter). Verification is expected to succeed as

+constraints on trust anchors are not enforced.."""

import common

@@ -25,8 +26,9 @@ chain = [target, intermediate]

trusted = [root]

# Both the target and intermediate are valid at this time, however the

-# root is not.

+# root is not. This doesn't matter since the root certificate is

+# just a delivery mechanism for the name + SPKI.

time = common.MARCH_2_2015_UTC

-verify_result = False

+verify_result = True

common.write_test_file(__doc__, chain, trusted, time, verify_result)