Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: components/cast_certificate/cast_crl.h

Issue 2225493003: Don't treat trust anchors as certificates during path building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address moar feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cast_certificate/cast_cert_validator.cc ('k') | components/cast_certificate/cast_crl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cast_certificate/cast_crl.h
diff --git a/components/cast_certificate/cast_crl.h b/components/cast_certificate/cast_crl.h
index f7d102a9b6b8fa63938fa12cc34109213e39e8fe..0ab6964fa03c25c26bdadea73e601d8b0aa8054b 100644
--- a/components/cast_certificate/cast_crl.h
+++ b/components/cast_certificate/cast_crl.h
@@ -16,6 +16,7 @@
namespace net {
class TrustStore;
+struct CertPath;
}
namespace cast_certificate {
@@ -29,17 +30,14 @@ class CastCRL {
// of X.509 certificates.
//
// Inputs:
- // * |certs| is the verified chain of X.509 certificates:
- // * |certs[0]| is the target certificate (i.e. the device certificate).
- // * |certs[i]| is the certificate that issued certs[i-1].
- // * |certs.back()| is assumed to be a trusted root.
+ // * |chain| the chain of verified certificates, including trust anchor.
//
// * |time| is the unix timestamp to use for determining if the certificate
// is revoked.
//
// Output:
// Returns true if no certificate in the chain was revoked.
- virtual bool CheckRevocation(const net::ParsedCertificateList& certs,
+ virtual bool CheckRevocation(const net::CertPath& chain,
const base::Time& time) const = 0;
};
« no previous file with comments | « components/cast_certificate/cast_cert_validator.cc ('k') | components/cast_certificate/cast_crl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698