Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: components/cast_certificate/cast_cert_validator.cc

Issue 2225493003: Don't treat trust anchors as certificates during path building. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address moar feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cast_certificate/cast_crl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cast_certificate/cast_cert_validator.cc
diff --git a/components/cast_certificate/cast_cert_validator.cc b/components/cast_certificate/cast_cert_validator.cc
index 9dcff2fe63f99412671f756366a8591e34027614..3e9bb222a2663bc9fb0fc8a33098d4826faaa013 100644
--- a/components/cast_certificate/cast_cert_validator.cc
+++ b/components/cast_certificate/cast_cert_validator.cc
@@ -67,12 +67,16 @@ class CastTrustStore {
// storage.
template <size_t N>
void AddAnchor(const uint8_t (&data)[N]) {
- scoped_refptr<net::ParsedCertificate> root =
+ scoped_refptr<net::ParsedCertificate> cert =
net::ParsedCertificate::CreateFromCertificateData(
data, N, net::ParsedCertificate::DataSource::EXTERNAL_REFERENCE,
{});
- CHECK(root);
- store_.AddTrustedCertificate(std::move(root));
+ CHECK(cert);
+ // TODO(crbug.com/635200): Support anchor constraints, and initialize the
+ // anchor using constraints from the self-signed certificate.
+ scoped_refptr<net::TrustAnchor> anchor =
+ net::TrustAnchor::CreateFromCertificateNoConstraints(std::move(cert));
+ store_.AddTrustAnchor(std::move(anchor));
}
net::TrustStore store_;
« no previous file with comments | « no previous file | components/cast_certificate/cast_crl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698