chrome/browser/devtools/devtools_ui_bindings.cc - Issue 2225343002: Navigation: move RestoreType and ReloadType into a separate file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 2225343002: Navigation: move RestoreType and ReloadType into a separate file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: trybots ran with PS8, but one more safe change is added here Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/icon_helper.h ('K') | « chrome/browser/chromeos/attestation/platform_verification_dialog.cc ('k') | chrome/browser/infobars/infobar_service.h » ('j') | content/browser/frame_host/navigation_entry_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index d0399b3a2752198a9b97b4a4ba32f11636af1cd7..99f74912be56b8aceb141ab2d6831d8b5017e52b 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -307,7 +307,7 @@ class DevToolsUIBindings::FrontendWebContentsObserver

void RenderProcessGone(base::TerminationStatus status) override;

void DidStartNavigationToPendingEntry(

const GURL& url,

- content::NavigationController::ReloadType reload_type) override;

+ content::ReloadType reload_type) override;

void DocumentAvailableInMainFrame() override;

void DocumentOnLoadCompletedInMainFrame() override;

void DidNavigateMainFrame(

@@ -350,9 +350,8 @@ void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone(

}

void DevToolsUIBindings::FrontendWebContentsObserver::

- DidStartNavigationToPendingEntry(

- const GURL& url,

- content::NavigationController::ReloadType reload_type) {

+ DidStartNavigationToPendingEntry(const GURL& url,

+ content::ReloadType reload_type) {

devtools_bindings_->frontend_host_.reset(

content::DevToolsFrontendHost::Create(

web_contents()->GetMainFrame(),