Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2225323002: MIPS: Implement Bovc and Bnvc instruction macros. (Closed)

Created:
4 years, 4 months ago by Marija Antic
Modified:
4 years, 4 months ago
Reviewers:
ivica.bogosavljevic, Ilija.Pavlovic1, balazs.kilvady, miran.karic, ilija.pavlovic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Implement Bovc and Bnvc instruction macros. Implement Bovc and Bnvc instruction macros in macro assembler. The change 6f920d7d59915e970a7d09bb6596605015c3bedd revealed an issue with AddBranchOvf for mips R6. All branching instructions other than BOVC and BNVC are handled by Branch macro, which assures correct handling of long and short branches. As a consequence, AddBranchOvf for R6 was working correctly only before trampoline was emitted, but the case of long branch was not handled at all. Implemented instruction macros enable proper handling of BOVC and BNVC in cases when long branching is needed. TEST=test/intl/general/case-mapping.js BUG= Committed: https://crrev.com/93809055aa7d58585d73cfa9fbf18b82340db2a1 Cr-Commit-Position: refs/heads/master@{#38513}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -5 lines) Patch
M src/mips/macro-assembler-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +23 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 1 chunk +73 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Marija Antic
PTAL
4 years, 4 months ago (2016-08-09 09:16:07 UTC) #2
Ilija.Pavlovic1
lgtm
4 years, 4 months ago (2016-08-09 12:51:32 UTC) #4
Ilija.Pavlovic1
lgtm
4 years, 4 months ago (2016-08-09 12:51:38 UTC) #5
akos.palfi.imgtec
LGTM
4 years, 4 months ago (2016-08-09 13:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225323002/20001
4 years, 4 months ago (2016-08-09 14:04:40 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
4 years, 4 months ago (2016-08-09 14:06:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225323002/20001
4 years, 4 months ago (2016-08-10 06:03:04 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 06:06:48 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:07:02 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93809055aa7d58585d73cfa9fbf18b82340db2a1
Cr-Commit-Position: refs/heads/master@{#38513}

Powered by Google App Engine
This is Rietveld 408576698