Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2225263003: Add missing methods to WebRtcAudioDeviceNotImpl. (Closed)

Created:
4 years, 4 months ago by Max Morin
Modified:
4 years, 4 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing methods to WebRtcAudioDeviceNotImpl. These will become pure virtual in WebRTC, so we need an implementation of them here, see https://codereview.webrtc.org/2222563002/ BUG=webrtc:6170 Committed: https://crrev.com/c2e6d38972b9b859379002454340a9cfb417570f Cr-Commit-Position: refs/heads/master@{#411947}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M content/renderer/media/webrtc_audio_device_not_impl.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_not_impl.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Max Morin
Per: PTAL at this small change.
4 years, 4 months ago (2016-08-09 10:12:31 UTC) #3
perkj_chrome
lgtm with the comments considered. please add the correct bug number to BUG= https://codereview.chromium.org/2225263003/diff/1/content/renderer/media/webrtc_audio_device_not_impl.cc File ...
4 years, 4 months ago (2016-08-15 05:23:11 UTC) #5
Max Morin
https://codereview.chromium.org/2225263003/diff/1/content/renderer/media/webrtc_audio_device_not_impl.cc File content/renderer/media/webrtc_audio_device_not_impl.cc (right): https://codereview.chromium.org/2225263003/diff/1/content/renderer/media/webrtc_audio_device_not_impl.cc#newcode270 content/renderer/media/webrtc_audio_device_not_impl.cc:270: return 0; On 2016/08/15 05:23:10, perkj_chrome wrote: > NOTREACHED() ...
4 years, 4 months ago (2016-08-15 07:13:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225263003/20001
4 years, 4 months ago (2016-08-15 07:41:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 08:24:38 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 08:25:51 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2e6d38972b9b859379002454340a9cfb417570f
Cr-Commit-Position: refs/heads/master@{#411947}

Powered by Google App Engine
This is Rietveld 408576698