Certificate Transparency: Change CTVerifyResult to have a single list

net/ssl/ssl_info.cc

Index: net/ssl/ssl_info.cc
diff --git a/net/ssl/ssl_info.cc b/net/ssl/ssl_info.cc
index ce7c949a0d2ce281b50bb144e2266cda5b4c7dd7..e57272543cef4af5d05fd829cf30d962583c2939 100644
--- a/net/ssl/ssl_info.cc
+++ b/net/ssl/ssl_info.cc
@@ -77,18 +77,10 @@ void SSLInfo::SetCertError(int error) {
 
 void SSLInfo::UpdateCertificateTransparencyInfo(
     const ct::CTVerifyResult& ct_verify_result) {
-  for (const auto& sct : ct_verify_result.verified_scts) {
-    signed_certificate_timestamps.push_back(
-        SignedCertificateTimestampAndStatus(sct, ct::SCT_STATUS_OK));
-  }
-  for (const auto& sct : ct_verify_result.invalid_scts) {
-    signed_certificate_timestamps.push_back(
-        SignedCertificateTimestampAndStatus(sct, ct::SCT_STATUS_INVALID));
-  }
-  for (const auto& sct : ct_verify_result.unknown_logs_scts) {
-    signed_certificate_timestamps.push_back(
-        SignedCertificateTimestampAndStatus(sct, ct::SCT_STATUS_LOG_UNKNOWN));
-  }
+  signed_certificate_timestamps.clear();

[eroman, 2016/08/10 19:00:40]

This behavior is different than previously, where it only appended. Is this
intentional?

If the intent is assignment, perhaps can write it more simply as:

signed_certificate_timestamps = ct_verify_result.scts;

[Eran Messeri, 2016/08/10 22:05:07]

Reverted to the previous behaviour - of appending at the end of the scts list
without clearing it.

+  signed_certificate_timestamps.insert(signed_certificate_timestamps.begin(),
+                                       ct_verify_result.scts.begin(),
+                                       ct_verify_result.scts.end());
 
   ct_compliance_details_available = ct_verify_result.ct_policies_applied;
   ct_cert_policy_compliance = ct_verify_result.cert_policy_compliance;