Certificate Transparency: Change CTVerifyResult to have a single list

net/test/ct_test_util.cc

Index: net/test/ct_test_util.cc
diff --git a/net/test/ct_test_util.cc b/net/test/ct_test_util.cc
index 3d79967f14f24e9c1220928ece2f522e18face23..d98fa21c4fee57a98d093e2c047aab4742191468 100644
--- a/net/test/ct_test_util.cc
+++ b/net/test/ct_test_util.cc
@@ -399,15 +399,15 @@ std::string GetSCTListWithInvalidSCT() {
 
 bool CheckForSingleVerifiedSCTInResult(const ct::CTVerifyResult& result,
                                        const std::string& log_description) {
-  return (result.verified_scts.size() == 1U) && result.invalid_scts.empty() &&
-         result.unknown_logs_scts.empty() &&
-         result.verified_scts[0]->log_description == log_description;
+  return (result.scts.size() == 1 &&
+          result.scts[0].status == ct::SCT_STATUS_OK &&
+          result.scts[0].sct->log_description == log_description);
 }
 
 bool CheckForSCTOrigin(const ct::CTVerifyResult& result,
                        ct::SignedCertificateTimestamp::Origin origin) {
-  return (result.verified_scts.size() > 0) &&
-         (result.verified_scts[0]->origin == origin);
+  return (result.scts.size() > 0) && (result.scts[0].status == SCT_STATUS_OK) &&

[eroman, 2016/08/10 19:00:40]

What are the guarantees around ordering? For more general code should this
search for a match instead of just looking at the first?

[Eran Messeri, 2016/08/10 22:05:07]

No guarantees indeed - Changed the code to look for a match.

+         (result.scts[0].sct->origin == origin);
 }
 
 }  // namespace ct