Certificate Transparency: Change CTVerifyResult to have a single list

chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

Index: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
index fcd4872dca24a49b1d8c3a40761ceeb7aefbd146..048629c9b6a77c6e3fe50fbfd13943cb27e190c5 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
@@ -192,22 +192,23 @@ void CheckReportSCTs(
       expected_scts.size(),
       unknown_scts.GetSize() + invalid_scts.GetSize() + valid_scts.GetSize());
   for (const auto& expected_sct : expected_scts) {
+    std::unique_ptr<base::ListValue> sct_list;

[estark, 2016/08/09 02:43:22]

Hrmm, not sure I understand this change, could you explain?

[Eran Messeri, 2016/08/09 08:14:21]

The goal was to save repeated calls to:

    ASSERT_NO_FATAL_FAILURE(FindSCTInReportList(
        expected_sct.sct, expected_sct.status, *(sct_list.get())));

But this change is not, strictly speaking, necessary, so I've reverted it.

     switch (expected_sct.status) {
       case net::ct::SCT_STATUS_LOG_UNKNOWN:
-        ASSERT_NO_FATAL_FAILURE(FindSCTInReportList(
-            expected_sct.sct, net::ct::SCT_STATUS_LOG_UNKNOWN, unknown_scts));
+        sct_list.reset(unknown_scts.DeepCopy());
         break;
       case net::ct::SCT_STATUS_INVALID:
-        ASSERT_NO_FATAL_FAILURE(FindSCTInReportList(
-            expected_sct.sct, net::ct::SCT_STATUS_INVALID, invalid_scts));
+        sct_list.reset(invalid_scts.DeepCopy());
         break;
       case net::ct::SCT_STATUS_OK:
-        ASSERT_NO_FATAL_FAILURE(FindSCTInReportList(
-            expected_sct.sct, net::ct::SCT_STATUS_OK, valid_scts));
+        sct_list.reset(valid_scts.DeepCopy());
         break;
       default:
         NOTREACHED();
     }
+
+    ASSERT_NO_FATAL_FAILURE(FindSCTInReportList(
+        expected_sct.sct, expected_sct.status, *(sct_list.get())));
   }
 }