Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: net/cert/ct_signed_certificate_timestamp_log_param.cc

Issue 2225223002: Certificate Transparency: Change CTVerifyResult to have a single list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/ct_signed_certificate_timestamp_log_param.cc
diff --git a/net/cert/ct_signed_certificate_timestamp_log_param.cc b/net/cert/ct_signed_certificate_timestamp_log_param.cc
index f829e56a8139ae1a24a40d5ce3f950af83f1b332..773ef65d4ab9b8fc5271e4062d92db9880e441cb 100644
--- a/net/cert/ct_signed_certificate_timestamp_log_param.cc
+++ b/net/cert/ct_signed_certificate_timestamp_log_param.cc
@@ -62,10 +62,12 @@ std::unique_ptr<base::DictionaryValue> SCTToDictionary(
// Given a list of SCTs, return a ListValue instance where each item in the
// list is a dictionary created by SCTToDictionary.
std::unique_ptr<base::ListValue> SCTListToPrintableValues(
- const ct::SCTList& sct_list) {
+ const SignedCertificateTimestampAndStatusList& sct_and_status_list,
+ ct::SCTVerifyStatus match_status) {
std::unique_ptr<base::ListValue> output_scts(new base::ListValue());
- for (const auto& sct : sct_list)
- output_scts->Append(SCTToDictionary(*(sct.get())));
+ for (const auto& sct_and_status : sct_and_status_list)
+ if (sct_and_status.status == match_status)
+ output_scts->Append(SCTToDictionary(*(sct_and_status.sct.get())));
return output_scts;
}
@@ -78,13 +80,14 @@ std::unique_ptr<base::Value> NetLogSignedCertificateTimestampCallback(
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->Set("verified_scts",
- SCTListToPrintableValues(ct_result->verified_scts));
+ SCTListToPrintableValues(ct_result->scts, ct::SCT_STATUS_OK));
dict->Set("invalid_scts",
- SCTListToPrintableValues(ct_result->invalid_scts));
+ SCTListToPrintableValues(ct_result->scts, ct::SCT_STATUS_INVALID));
- dict->Set("unknown_logs_scts",
- SCTListToPrintableValues(ct_result->unknown_logs_scts));
+ dict->Set(
+ "unknown_logs_scts",
+ SCTListToPrintableValues(ct_result->scts, ct::SCT_STATUS_LOG_UNKNOWN));
return std::move(dict);
}

Powered by Google App Engine
This is Rietveld 408576698