Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: chrome/browser/ssl/chrome_ssl_host_state_delegate.cc

Issue 2225213004: Teach SSLHostStateDelegate about subresources with cert errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
diff --git a/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc b/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
index 7d2fdfe27313ed2b82b05e905545eb20ded06ad9..f6e31e05d74e600f8da202789f65d9e96a4fb207 100644
--- a/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
+++ b/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
@@ -434,15 +434,33 @@ bool ChromeSSLHostStateDelegate::HasAllowException(
return false;
}
-void ChromeSSLHostStateDelegate::HostRanInsecureContent(const std::string& host,
- int pid) {
- ran_insecure_content_hosts_.insert(BrokenHostEntry(host, pid));
+void ChromeSSLHostStateDelegate::HostRanInsecureContent(
+ const std::string& host,
+ int pid,
+ InsecureContentType content_type) {
+ switch (content_type) {
+ case MIXED_CONTENT:
+ ran_mixed_content_hosts_.insert(BrokenHostEntry(host, pid));
+ return;
+ case CERT_ERRORS_CONTENT:
+ ran_content_with_cert_errors_hosts_.insert(BrokenHostEntry(host, pid));
+ return;
+ }
}
bool ChromeSSLHostStateDelegate::DidHostRunInsecureContent(
const std::string& host,
- int pid) const {
- return !!ran_insecure_content_hosts_.count(BrokenHostEntry(host, pid));
+ int pid,
+ InsecureContentType content_type) const {
+ switch (content_type) {
+ case MIXED_CONTENT:
+ return !!ran_mixed_content_hosts_.count(BrokenHostEntry(host, pid));
+ case CERT_ERRORS_CONTENT:
+ return !!ran_content_with_cert_errors_hosts_.count(
+ BrokenHostEntry(host, pid));
+ }
+ NOTREACHED();
+ return false;
}
void ChromeSSLHostStateDelegate::SetClock(std::unique_ptr<base::Clock> clock) {
clock_.reset(clock.release());
« no previous file with comments | « chrome/browser/ssl/chrome_ssl_host_state_delegate.h ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698