Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2351)

Unified Diff: chrome/browser/ssl/chrome_ssl_host_state_delegate.h

Issue 2225213004: Teach SSLHostStateDelegate about subresources with cert errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_ssl_host_state_delegate.h
diff --git a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
index 8a01205cdb47cd450cf0f42cfc80a970d9f87eec..b958a1daa4888847b68983d755a583f08daf6d97 100644
--- a/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
+++ b/chrome/browser/ssl/chrome_ssl_host_state_delegate.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_SSL_CHROME_SSL_HOST_STATE_DELEGATE_H_
#include <memory>
+#include <set>
#include "base/gtest_prod_util.h"
#include "base/macros.h"
@@ -37,9 +38,13 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
const net::X509Certificate& cert,
net::CertStatus error,
bool* expired_previous_decision) override;
- void HostRanInsecureContent(const std::string& host, int pid) override;
- bool DidHostRunInsecureContent(const std::string& host,
- int pid) const override;
+ void HostRanInsecureContent(const std::string& host,
+ int pid,
+ InsecureContentType content_type) override;
+ bool DidHostRunInsecureContent(
+ const std::string& host,
+ int pid,
+ InsecureContentType content_type) const override;
// Revokes all SSL certificate error allow exceptions made by the user for
// |host| in the given Profile.
@@ -110,10 +115,14 @@ class ChromeSSLHostStateDelegate : public content::SSLHostStateDelegate {
// contains insecure content in that renderer process.
typedef std::pair<std::string, int> BrokenHostEntry;
- // Hosts which have been contaminated with insecure content in the
+ // Hosts which have been contaminated with insecure mixed content in the
// specified process. Note that insecure content can travel between
// same-origin frames in one processs but cannot jump between processes.
- std::set<BrokenHostEntry> ran_insecure_content_hosts_;
+ std::set<BrokenHostEntry> ran_mixed_content_hosts_;
+
+ // Hosts which have been contaminated with content with certificate errors in
+ // the specific process.
+ std::set<BrokenHostEntry> ran_content_with_cert_errors_hosts_;
// This is a GUID to mark this unique session. Whenever a certificate decision
// expiration is set, the GUID is saved as well so Chrome can tell if it was
« no previous file with comments | « android_webview/browser/aw_ssl_host_state_delegate.cc ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698