Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2225133002: Revert "Port WebSockets to Mojo IPC" (Closed)

Created:
4 years, 4 months ago by darin (slow to review)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Port WebSockets to Mojo IPC" This reverts commit 2b78d9ee821f4d5c8c31a05028360610f5d0069f due to memory corruption issues. TBR=jam@chromium.org,tsepez@chromium.org BUG=635397, 635602 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/815c4cbb961e3c077f96b084cd00737f82035da3 Cr-Commit-Position: refs/heads/master@{#410456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3553 lines, -1751 lines) Patch
M content/browser/bad_message.h View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/bad_message.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +10 lines, -7 lines 0 comments Download
A content/browser/renderer_host/websocket_blob_sender.h View 1 chunk +140 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_blob_sender.cc View 1 chunk +284 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_blob_sender_unittest.cc View 1 chunk +450 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_dispatcher_host.h View 1 chunk +212 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_dispatcher_host.cc View 1 chunk +310 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_dispatcher_host_unittest.cc View 1 chunk +468 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_host.h View 1 chunk +126 lines, -0 lines 0 comments Download
A content/browser/renderer_host/websocket_host.cc View 1 chunk +606 lines, -0 lines 0 comments Download
D content/browser/websockets/websocket_impl.h View 1 chunk +0 lines, -112 lines 0 comments Download
D content/browser/websockets/websocket_impl.cc View 1 chunk +0 lines, -536 lines 0 comments Download
D content/browser/websockets/websocket_manager.h View 1 chunk +0 lines, -86 lines 0 comments Download
D content/browser/websockets/websocket_manager.cc View 1 chunk +0 lines, -176 lines 0 comments Download
D content/browser/websockets/websocket_manager_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
M content/child/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.h View 5 chunks +14 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +7 lines, -0 lines 0 comments Download
A content/child/websocket_bridge.h View 1 chunk +77 lines, -0 lines 0 comments Download
A content/child/websocket_bridge.cc View 1 chunk +304 lines, -0 lines 0 comments Download
A content/child/websocket_dispatcher.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/child/websocket_dispatcher.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A content/child/websocket_message_filter.h View 1 chunk +50 lines, -0 lines 0 comments Download
A content/child/websocket_message_filter.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/websocket.h View 1 chunk +64 lines, -0 lines 0 comments Download
A content/common/websocket.cc View 1 chunk +18 lines, -0 lines 0 comments Download
D content/common/websocket.mojom View 1 chunk +0 lines, -138 lines 0 comments Download
A content/common/websocket_messages.h View 1 chunk +201 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +6 lines, -4 lines 0 comments Download
M content/content_child.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/OWNERS View 1 chunk +1 line, -6 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D content/renderer/websockethandle_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/renderer/websockethandle_impl.cc View 1 chunk +0 lines, -302 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225133002/1
4 years, 4 months ago (2016-08-08 19:09:14 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-08 19:09:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225133002/1
4 years, 4 months ago (2016-08-08 19:15:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/214290)
4 years, 4 months ago (2016-08-08 19:26:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225133002/1
4 years, 4 months ago (2016-08-08 19:37:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/214309)
4 years, 4 months ago (2016-08-08 20:04:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2225133002/1
4 years, 4 months ago (2016-08-08 20:33:26 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 21:06:50 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 21:09:52 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/815c4cbb961e3c077f96b084cd00737f82035da3
Cr-Commit-Position: refs/heads/master@{#410456}

Powered by Google App Engine
This is Rietveld 408576698