Issue 2225123002: [Mac] Convert a DCHECK to a condition in safe_browsing::dmg::UDIFBlockChunkReadStream::Seek.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2225123002: [Mac] Convert a DCHECK to a condition in safe_browsing::dmg::UDIFBlockChunkReadStream::Seek. (Closed)

Created:
4 years, 4 months ago by Robert Sesek

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[Mac] Convert a DCHECK to a condition in safe_browsing::dmg::UDIFBlockChunkReadStream::Seek. BUG=627355 Review-Url: https://codereview.chromium.org/2202343004 Cr-Commit-Position: refs/heads/master@{#409324} (cherry picked from commit e1a415e9785da06e836c9929ec764487a4abb80f) Committed: https://chromium.googlesource.com/chromium/src/+/9fa921f0231392e89c9bd2280bb18224591e7f13

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/utility/safe_browsing/mac/udif.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Robert Sesek

4 years, 4 months ago (2016-08-08 19:06:36 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9fa921f0231392e89c9bd2280bb18224591e7f13 (tree was closed).