Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2202343004: [Mac] Convert a DCHECK to a condition in safe_browsing::dmg::UDIFBlockChunkReadStream::Seek. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Convert a DCHECK to a condition in safe_browsing::dmg::UDIFBlockChunkReadStream::Seek. BUG=627355 Committed: https://crrev.com/e1a415e9785da06e836c9929ec764487a4abb80f Cr-Commit-Position: refs/heads/master@{#409324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/utility/safe_browsing/mac/udif.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
4 years, 4 months ago (2016-08-02 20:41:35 UTC) #5
Nathan Parker
lgtm
4 years, 4 months ago (2016-08-02 21:03:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202343004/1
4 years, 4 months ago (2016-08-02 21:10:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 21:26:47 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 21:29:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1a415e9785da06e836c9929ec764487a4abb80f
Cr-Commit-Position: refs/heads/master@{#409324}

Powered by Google App Engine
This is Rietveld 408576698