third_party/WebKit/Source/core/paint/TableRowPainter.cpp - Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TableRowPainter.cpp

Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: - Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/TableCellPainter.cpp ('k') | third_party/WebKit/Source/core/paint/TableSectionPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TableRowPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/TableRowPainter.cpp b/third_party/WebKit/Source/core/paint/TableRowPainter.cpp

index 635fdfee9ec6a68e7056a4e3102740fb5eae6264..0735dc57de67a05e9fcfea9d8ddb7e56d55acd56 100644

--- a/third_party/WebKit/Source/core/paint/TableRowPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/TableRowPainter.cpp

@@ -27,7 +27,7 @@ void TableRowPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paint

PaintInfo paintInfoForCells = paintInfo.forDescendants();

if (shouldPaintSelfBlockBackground(paintInfo.phase)) {

paintBoxShadow(paintInfo, paintOffset, Normal);

- if (m_layoutTableRow.hasBackground()) {

+ if (m_layoutTableRow.styleRef().hasBackground()) {

// Paint row background of behind the cells.

for (LayoutTableCell* cell = m_layoutTableRow.firstCell(); cell; cell = cell->nextCell())

TableCellPainter(*cell).paintContainerBackgroundBehindCell(paintInfoForCells, paintOffset, m_layoutTableRow, DisplayItem::TableCellBackgroundFromRow);

@@ -69,7 +69,7 @@ void TableRowPainter::paintBoxShadow(const PaintInfo& paintInfo, const LayoutPoi

void TableRowPainter::paintBackgroundBehindCell(const LayoutTableCell& cell, const PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

- DCHECK(m_layoutTableRow.hasBackground() && !m_layoutTableRow.hasSelfPaintingLayer());

+ DCHECK(m_layoutTableRow.styleRef().hasBackground() && !m_layoutTableRow.hasSelfPaintingLayer());

LayoutPoint cellPoint = m_layoutTableRow.section()->flipForWritingModeForChild(&cell, paintOffset);

TableCellPainter(cell).paintContainerBackgroundBehindCell(paintInfo, cellPoint, m_layoutTableRow, DisplayItem::TableCellBackgroundFromRow);

}