Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: third_party/WebKit/Source/core/paint/TableRowPainter.cpp

Issue 2225033003: Separate backgroundObscurationStatus and hasBoxDecorationBackground (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: - Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/paint/TableRowPainter.h" 5 #include "core/paint/TableRowPainter.h"
6 6
7 #include "core/layout/LayoutTableCell.h" 7 #include "core/layout/LayoutTableCell.h"
8 #include "core/layout/LayoutTableRow.h" 8 #include "core/layout/LayoutTableRow.h"
9 #include "core/paint/BoxPainter.h" 9 #include "core/paint/BoxPainter.h"
10 #include "core/paint/LayoutObjectDrawingRecorder.h" 10 #include "core/paint/LayoutObjectDrawingRecorder.h"
11 #include "core/paint/ObjectPainter.h" 11 #include "core/paint/ObjectPainter.h"
12 #include "core/paint/PaintInfo.h" 12 #include "core/paint/PaintInfo.h"
13 #include "core/paint/TableCellPainter.h" 13 #include "core/paint/TableCellPainter.h"
14 14
15 namespace blink { 15 namespace blink {
16 16
17 void TableRowPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paint Offset) 17 void TableRowPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paint Offset)
18 { 18 {
19 DCHECK(m_layoutTableRow.hasSelfPaintingLayer()); 19 DCHECK(m_layoutTableRow.hasSelfPaintingLayer());
20 20
21 // TODO(crbug.com/577282): This painting order is inconsistent with other ou tlines. 21 // TODO(crbug.com/577282): This painting order is inconsistent with other ou tlines.
22 if (shouldPaintSelfOutline(paintInfo.phase)) 22 if (shouldPaintSelfOutline(paintInfo.phase))
23 paintOutline(paintInfo, paintOffset); 23 paintOutline(paintInfo, paintOffset);
24 if (paintInfo.phase == PaintPhaseSelfOutlineOnly) 24 if (paintInfo.phase == PaintPhaseSelfOutlineOnly)
25 return; 25 return;
26 26
27 PaintInfo paintInfoForCells = paintInfo.forDescendants(); 27 PaintInfo paintInfoForCells = paintInfo.forDescendants();
28 if (shouldPaintSelfBlockBackground(paintInfo.phase)) { 28 if (shouldPaintSelfBlockBackground(paintInfo.phase)) {
29 paintBoxShadow(paintInfo, paintOffset, Normal); 29 paintBoxShadow(paintInfo, paintOffset, Normal);
30 if (m_layoutTableRow.hasBackground()) { 30 if (m_layoutTableRow.styleRef().hasBackground()) {
31 // Paint row background of behind the cells. 31 // Paint row background of behind the cells.
32 for (LayoutTableCell* cell = m_layoutTableRow.firstCell(); cell; cel l = cell->nextCell()) 32 for (LayoutTableCell* cell = m_layoutTableRow.firstCell(); cell; cel l = cell->nextCell())
33 TableCellPainter(*cell).paintContainerBackgroundBehindCell(paint InfoForCells, paintOffset, m_layoutTableRow, DisplayItem::TableCellBackgroundFro mRow); 33 TableCellPainter(*cell).paintContainerBackgroundBehindCell(paint InfoForCells, paintOffset, m_layoutTableRow, DisplayItem::TableCellBackgroundFro mRow);
34 } 34 }
35 paintBoxShadow(paintInfo, paintOffset, Inset); 35 paintBoxShadow(paintInfo, paintOffset, Inset);
36 } 36 }
37 37
38 if (paintInfo.phase == PaintPhaseSelfBlockBackgroundOnly) 38 if (paintInfo.phase == PaintPhaseSelfBlockBackgroundOnly)
39 return; 39 return;
40 40
(...skipping 21 matching lines...) Expand all
62 return; 62 return;
63 63
64 LayoutPoint adjustedPaintOffset = paintOffset + m_layoutTableRow.location(); 64 LayoutPoint adjustedPaintOffset = paintOffset + m_layoutTableRow.location();
65 LayoutRect bounds = BoxPainter(m_layoutTableRow).boundsForDrawingRecorder(ad justedPaintOffset); 65 LayoutRect bounds = BoxPainter(m_layoutTableRow).boundsForDrawingRecorder(ad justedPaintOffset);
66 LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutTableRow, ty pe, bounds); 66 LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutTableRow, ty pe, bounds);
67 BoxPainter::paintBoxShadow(paintInfo, LayoutRect(adjustedPaintOffset, m_layo utTableRow.size()), m_layoutTableRow.styleRef(), shadowStyle); 67 BoxPainter::paintBoxShadow(paintInfo, LayoutRect(adjustedPaintOffset, m_layo utTableRow.size()), m_layoutTableRow.styleRef(), shadowStyle);
68 } 68 }
69 69
70 void TableRowPainter::paintBackgroundBehindCell(const LayoutTableCell& cell, con st PaintInfo& paintInfo, const LayoutPoint& paintOffset) 70 void TableRowPainter::paintBackgroundBehindCell(const LayoutTableCell& cell, con st PaintInfo& paintInfo, const LayoutPoint& paintOffset)
71 { 71 {
72 DCHECK(m_layoutTableRow.hasBackground() && !m_layoutTableRow.hasSelfPainting Layer()); 72 DCHECK(m_layoutTableRow.styleRef().hasBackground() && !m_layoutTableRow.hasS elfPaintingLayer());
73 LayoutPoint cellPoint = m_layoutTableRow.section()->flipForWritingModeForChi ld(&cell, paintOffset); 73 LayoutPoint cellPoint = m_layoutTableRow.section()->flipForWritingModeForChi ld(&cell, paintOffset);
74 TableCellPainter(cell).paintContainerBackgroundBehindCell(paintInfo, cellPoi nt, m_layoutTableRow, DisplayItem::TableCellBackgroundFromRow); 74 TableCellPainter(cell).paintContainerBackgroundBehindCell(paintInfo, cellPoi nt, m_layoutTableRow, DisplayItem::TableCellBackgroundFromRow);
75 } 75 }
76 76
77 } // namespace blink 77 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698