Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

We had two issues.

* 'menulist' and 'menulist-button' appearances were not RTL-aware on macOS
  They are used for <select> and <input type=color list>.
  They were always rendered in LTR.

* Paddings of <input type=color list> were not RTL-aware on all platforms.

This CL fixes them.

BUG=232333
Committed: https://crrev.com/c371a8f73eba6d83bea5889cf4ae0679b689703d
Cr-Commit-Position: refs/heads/master@{#410534}

[tkent, 2016-08-08 08:30:14]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 08:30:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-08 08:50:53]

Description was changed from

==========
Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

BUG=232333
==========

to

==========
Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

We had two issues.

* 'menulist' and 'menulist-button' appearances were not RTL-aware on macOS
  They are used for <select> and <input type=color list>.
  They were always rendered in LTR.

* Paddings of <input type=color list> was not RTL-aware on all platforms.

This CL fixes them.


BUG=232333
==========

[tkent, 2016-08-08 08:51:04]

Description was changed from

==========
Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

We had two issues.

* 'menulist' and 'menulist-button' appearances were not RTL-aware on macOS
  They are used for <select> and <input type=color list>.
  They were always rendered in LTR.

* Paddings of <input type=color list> was not RTL-aware on all platforms.

This CL fixes them.


BUG=232333
==========

to

==========
Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

We had two issues.

* 'menulist' and 'menulist-button' appearances were not RTL-aware on macOS
  They are used for <select> and <input type=color list>.
  They were always rendered in LTR.

* Paddings of <input type=color list> were not RTL-aware on all platforms.

This CL fixes them.


BUG=232333
==========

[commit-bot: I haz the power, 2016-08-08 09:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 09:59:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2016-08-08 23:58:37]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:59:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-09 00:32:31]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-09 00:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:34:07]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tkent, 2016-08-09 01:04:30]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-08-09 01:04:31]

keishi@, would you review this please?

https://codereview.chromium.org/2224883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutThemeMac.mm (right):

https://codereview.chromium.org/2224883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutThemeMac.mm:479: //
NSPopUpButtonCell on macOS 10.9 doesn't support
Actually, I don't know the status of macOS 10.10.  I'll watch rebaseline bot
result carefully, and update the code if necessary.

[keishi, 2016-08-09 01:28:00]

LGTM

[tkent, 2016-08-09 01:39:12]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:39:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 02:26:29]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-09 02:28:14]

Description was changed from

==========
Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

We had two issues.

* 'menulist' and 'menulist-button' appearances were not RTL-aware on macOS
  They are used for <select> and <input type=color list>.
  They were always rendered in LTR.

* Paddings of <input type=color list> were not RTL-aware on all platforms.

This CL fixes them.


BUG=232333
==========

to

==========
Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

We had two issues.

* 'menulist' and 'menulist-button' appearances were not RTL-aware on macOS
  They are used for <select> and <input type=color list>.
  They were always rendered in LTR.

* Paddings of <input type=color list> were not RTL-aware on all platforms.

This CL fixes them.

BUG=232333

Committed: https://crrev.com/c371a8f73eba6d83bea5889cf4ae0679b689703d
Cr-Commit-Position: refs/heads/master@{#410534}
==========

[commit-bot: I haz the power, 2016-08-09 02:28:15]

Patchset 1 (id:??) landed as
https://crrev.com/c371a8f73eba6d83bea5889cf4ae0679b689703d
Cr-Commit-Position: refs/heads/master@{#410534}

[tkent, 2016-08-09 03:59:18]

https://codereview.chromium.org/2224883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutThemeMac.mm (right):

https://codereview.chromium.org/2224883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutThemeMac.mm:479: //
NSPopUpButtonCell on macOS 10.9 doesn't support
On 2016/08/09 at 01:04:31, tkent wrote:
> Actually, I don't know the status of macOS 10.10.  I'll watch rebaseline bot
result carefully, and update the code if necessary.

https://codereview.chromium.org/2223373002/ showed NSPopUpButtonCell on macOS
10.10 supported RTL rendering. We don't need to update the code.