Fix RTL rendering of SELECT on macOS and input[type=color] on all platforms.

third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 458 matching lines @@
         // can however detect that we're zooming. If zooming is in effect we
         // treat it like the control is styled.
         if (style.effectiveZoom() != 1.0f)
             return true;
         if (!fontSizeMatchesToControlSize(style))
             return true;
         if (style.getFontDescription().family().family() != "BlinkMacSystemFont")
             return true;
         if (!style.height().isIntrinsicOrAuto())
             return true;
+        // NSPopUpButtonCell on macOS 10.9 doesn't support

[tkent, 2016/08/09 01:04:31]

Actually, I don't know the status of macOS 10.10.  I'll watch rebaseline bot
result carefully, and update the code if necessary.

[tkent, 2016/08/09 03:59:17]

https://codereview.chromium.org/2223373002/ showed NSPopUpButtonCell on macOS
10.10 supported RTL rendering. We don't need to update the code.

+        // NSUserInterfaceLayoutDirectionRightToLeft.
+        if (IsOSMavericks() && style.direction() == RTL)
+            return true;
     }
     // Some other cells don't work well when scaled.
     if (style.effectiveZoom() != 1) {
         switch (style.appearance()) {
         case ButtonPart:
         case PushButtonPart:
         case SearchFieldPart:
         case SquareButtonPart:
             return true;
         default:
@@ skipping 251 matching lines @@
 
     // Our font is locked to the appropriate system font size for the
     // control. To clarify, we first use the CSS-specified font to figure out a
     // reasonable control size, but once that control size is determined, we
     // throw that font away and use the appropriate system font for the control
     // size instead.
     setFontFromControlSize(style, controlSize);
 }
 
 static const int baseBorderRadius = 5;
-static const int styledPopupPaddingLeft = 8;
+static const int styledPopupPaddingStart = 8;
 static const int styledPopupPaddingTop = 1;
 static const int styledPopupPaddingBottom = 2;
 
 // These functions are called with MenuListPart or MenulistButtonPart appearance
 // by LayoutMenuList.
 int LayoutThemeMac::popupInternalPaddingLeft(const ComputedStyle& style) const
 {
+    bool isRTL = style.direction() == RTL;
     if (style.appearance() == MenulistPart)
-        return popupButtonPadding(controlSizeForFont(style))[ThemeMac::LeftMargin] * style.effectiveZoom();
-    if (style.appearance() == MenulistButtonPart)
-        return styledPopupPaddingLeft * style.effectiveZoom();
-    return 0;
+        return popupButtonPadding(controlSizeForFont(style))[isRTL ? ThemeMac::RightMargin : ThemeMac::LeftMargin] * style.effectiveZoom();
+    if (style.appearance() != MenulistButtonPart)
+        return 0;
+    if (isRTL) {
+        float fontScale = style.fontSize() / baseFontSize;
+        float arrowWidth = menuListBaseArrowWidth * fontScale;
+        return static_cast<int>(ceilf(arrowWidth + (menuListArrowPaddingStart + menuListArrowPaddingEnd) * style.effectiveZoom()));
+    }
+    return styledPopupPaddingStart * style.effectiveZoom();
 }
 
 int LayoutThemeMac::popupInternalPaddingRight(const ComputedStyle& style) const
 {
+    bool isRTL = style.direction() == RTL;
     if (style.appearance() == MenulistPart)
-        return popupButtonPadding(controlSizeForFont(style))[ThemeMac::RightMargin] * style.effectiveZoom();
-    if (style.appearance() == MenulistButtonPart) {
-        float fontScale = style.fontSize() / baseFontSize;
-        float arrowWidth = menuListBaseArrowWidth * fontScale;
-        return static_cast<int>(ceilf(arrowWidth + (menuListArrowPaddingLeft + menuListArrowPaddingRight) * style.effectiveZoom()));
+        return popupButtonPadding(controlSizeForFont(style))[isRTL ? ThemeMac::LeftMargin : ThemeMac::RightMargin] * style.effectiveZoom();
+    if (style.appearance() != MenulistButtonPart)
+        return 0;
+    if (isRTL) {
+        return styledPopupPaddingStart * style.effectiveZoom();
     }
-    return 0;
+    float fontScale = style.fontSize() / baseFontSize;
+    float arrowWidth = menuListBaseArrowWidth * fontScale;
+    return static_cast<int>(ceilf(arrowWidth + (menuListArrowPaddingStart + menuListArrowPaddingEnd) * style.effectiveZoom()));
 }
 
 int LayoutThemeMac::popupInternalPaddingTop(const ComputedStyle& style) const
 {
     if (style.appearance() == MenulistPart)
         return popupButtonPadding(controlSizeForFont(style))[ThemeMac::TopMargin] * style.effectiveZoom();
     if (style.appearance() == MenulistButtonPart)
         return styledPopupPaddingTop * style.effectiveZoom();
     return 0;
 }
@@ skipping 25 matching lines @@
     NSPopUpButtonCell* popupButton = this->popupButton();
 
     // Set the control size based off the rectangle we're painting into.
     setControlSize(popupButton, popupButtonSizes(), rect.size(), object.styleRef().effectiveZoom());
 
     // Update the various states we respond to.
     updateActiveState(popupButton, object);
     updateCheckedState(popupButton, object);
     updateEnabledState(popupButton, object);
     updatePressedState(popupButton, object);
+
+    popupButton.userInterfaceLayoutDirection = object.styleRef().direction() == LTR ? NSUserInterfaceLayoutDirectionLeftToRight : NSUserInterfaceLayoutDirectionRightToLeft;
 }
 
 const IntSize* LayoutThemeMac::menuListSizes() const
 {
     static const IntSize sizes[3] = { IntSize(9, 0), IntSize(5, 0), IntSize(0, 0) };
     return sizes;
 }
 
 int LayoutThemeMac::minimumMenuListSize(const ComputedStyle& style) const
 {
@@ skipping 271 matching lines @@
 
 bool LayoutThemeMac::shouldUseFallbackTheme(const ComputedStyle& style) const
 {
     ControlPart part = style.appearance();
     if (part == CheckboxPart || part == RadioPart)
         return style.effectiveZoom() != 1;
     return false;
 }
 
 } // namespace blink