Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2224843002: Fix broken installer tests. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 4 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kill_al_win
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken installer tests. This CL fixes installer tests that were broken by r409132 which removed the app launcher from Windows but didn't update the installer tests that checked app launcher registry values. BUG=633490 Committed: https://crrev.com/1bde23cb81318ed369308b3f6063292990acf88b Cr-Commit-Position: refs/heads/master@{#410945}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : address comment #

Patch Set 4 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/installer/setup/uninstall.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_single_user_installed.prop View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_system_installed.prop View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/mini_installer/config/chrome_user_installed.prop View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download

Depends on Patchset:

Issue 2143893002 Patch 300001

Messages

Total messages: 10 (3 generated)
calamity
4 years, 4 months ago (2016-08-08 07:55:24 UTC) #2
grt (UTC plus 2)
https://codereview.chromium.org/2224843002/diff/20001/chrome/test/mini_installer/config/chrome_single_user_installed.prop File chrome/test/mini_installer/config/chrome_single_user_installed.prop (left): https://codereview.chromium.org/2224843002/diff/20001/chrome/test/mini_installer/config/chrome_single_user_installed.prop#oldcode27 chrome/test/mini_installer/config/chrome_single_user_installed.prop:27: "exists": "required", how about changing this to "forbidden" so ...
4 years, 4 months ago (2016-08-08 11:38:18 UTC) #3
calamity
https://codereview.chromium.org/2224843002/diff/20001/chrome/test/mini_installer/config/chrome_single_user_installed.prop File chrome/test/mini_installer/config/chrome_single_user_installed.prop (left): https://codereview.chromium.org/2224843002/diff/20001/chrome/test/mini_installer/config/chrome_single_user_installed.prop#oldcode27 chrome/test/mini_installer/config/chrome_single_user_installed.prop:27: "exists": "required", On 2016/08/08 11:38:17, grt (UTC plus 2) ...
4 years, 4 months ago (2016-08-09 06:46:14 UTC) #4
grt (UTC plus 2)
lgtm
4 years, 4 months ago (2016-08-09 11:35:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224843002/60001
4 years, 4 months ago (2016-08-10 02:47:45 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-10 03:34:46 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 03:36:42 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/1bde23cb81318ed369308b3f6063292990acf88b
Cr-Commit-Position: refs/heads/master@{#410945}

Powered by Google App Engine
This is Rietveld 408576698