chrome/test/mini_installer/config/chrome_system_installed.prop - Issue 2224843002: Fix broken installer tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer/config/chrome_system_installed.prop

Issue 2224843002: Fix broken installer tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kill_al_win

Patch Set: address comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/mini_installer/config/chrome_system_installed.prop

diff --git a/chrome/test/mini_installer/config/chrome_system_installed.prop b/chrome/test/mini_installer/config/chrome_system_installed.prop

index a11cde454690f6188206658bd4badc45ee2bca61..6b358aa3ca49cf26406abfef186f4a8d3e882572 100644

--- a/chrome/test/mini_installer/config/chrome_system_installed.prop

+++ b/chrome/test/mini_installer/config/chrome_system_installed.prop

@@ -28,10 +28,7 @@

"HKEY_LOCAL_MACHINE\\$LAUNCHER_UPDATE_REGISTRY_SUBKEY": {

"condition": "'$CHROME_SHORT_NAME' == 'Chrome'",

- "exists": "required",

- "values": {

- "pv": {"type": "SZ", "data": "$MINI_INSTALLER_FILE_VERSION"}

- }

+ "exists": "forbidden"

"HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\$CHROME_LONG_NAME": {

"exists": "required",