Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2224833002: [css-flexbox] Have to use forceChildLayout to force layout (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Have to use forceChildLayout to force layout The flexbox code was assuming that calling layoutIfNeeded() will do a full layout if needsLayout() is true. However, that is not the case. It is possible for needsLayout() to return true because posChildNeedsLayout is true, in which case calling layout() will not do the full layout that the flexbox code expects. Instead, call forceChildLayout to ensure that layout happens. R=eae@chromium.org,dgrogan@chromium.org CC=szager@chromium.org BUG=633212, 629491 Review-Url: https://codereview.chromium.org/2219433002 Cr-Commit-Position: refs/heads/master@{#410135} (cherry picked from commit e929360ccd93a1e98db3b19929a68d1ed4fa4d5d) Committed: https://chromium.googlesource.com/chromium/src/+/92a2a1f5852a882ef9671a8d792313dc670ac899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/bug633212.html View 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 4 months ago (2016-08-08 02:39:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92a2a1f5852a882ef9671a8d792313dc670ac899.

Powered by Google App Engine
This is Rietveld 408576698