Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2219433002: [css-flexbox] Have to use forceChildLayout to force layout (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Have to use forceChildLayout to force layout The flexbox code was assuming that calling layoutIfNeeded() will do a full layout if needsLayout() is true. However, that is not the case. It is possible for needsLayout() to return true because posChildNeedsLayout is true, in which case calling layout() will not do the full layout that the flexbox code expects. Instead, call forceChildLayout to ensure that layout happens. R=eae@chromium.org,dgrogan@chromium.org CC=szager@chromium.org BUG=633212, 629491 Committed: https://crrev.com/e929360ccd93a1e98db3b19929a68d1ed4fa4d5d Cr-Commit-Position: refs/heads/master@{#410135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/bug633212.html View 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
cbiesinger
4 years, 4 months ago (2016-08-04 19:48:33 UTC) #1
cbiesinger
A note on the testcase: the original bug report required resizing the window, but I ...
4 years, 4 months ago (2016-08-04 19:50:21 UTC) #4
eae
LGTM
4 years, 4 months ago (2016-08-05 19:10:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219433002/1
4 years, 4 months ago (2016-08-05 19:12:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:17:46 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:21:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e929360ccd93a1e98db3b19929a68d1ed4fa4d5d
Cr-Commit-Position: refs/heads/master@{#410135}

Powered by Google App Engine
This is Rietveld 408576698