Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2224753002: SkLiteDL: closing in (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkLiteDL: closing in - optimizeFor(GrContext*) - images - basic text BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224753002 Committed: https://skia.googlesource.com/skia/+/ec559591ae8f2c7005ad3824b718df5f01747851

Patch Set 1 #

Patch Set 2 : images except lattice #

Patch Set 3 : draw text #

Patch Set 4 : pos text #

Patch Set 5 : much tidier #

Patch Set 6 : memcpy_v makes things less error-prone #

Patch Set 7 : tidy up... only structs in namespace{} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -29 lines) Patch
M src/core/SkLiteDL.h View 1 2 3 2 chunks +20 lines, -13 lines 0 comments Download
M src/core/SkLiteDL.cpp View 1 2 3 4 5 6 5 chunks +179 lines, -14 lines 0 comments Download
M src/core/SkLiteRecorder.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein
lgtm
4 years, 4 months ago (2016-08-07 02:43:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224753002/60001
4 years, 4 months ago (2016-08-07 02:44:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224753002/120001
4 years, 4 months ago (2016-08-07 03:14:03 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-07 03:31:34 UTC) #13
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/ec559591ae8f2c7005ad3824b718df5f01747851

Powered by Google App Engine
This is Rietveld 408576698