Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 222473004: Fix scrolling fixed objs containing abs pos obj (Closed)

Created:
6 years, 8 months ago by ykyyip
Modified:
6 years, 8 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews
Visibility:
Public.

Description

Fix scrolling fixed objects containing abs pos objects Need to recalculate the repaint rects for children inside fixed objects when we find the repaint rects for fixed objects after scrolling so we invalidate the fixed objects with the correct scroll position. BUG=358550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
A LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll.html View 1 chunk +65 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll-expected.png View Binary file 0 comments Download
A LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ykyyip
6 years, 8 months ago (2014-04-02 19:38:53 UTC) #1
esprehn
lgtm
6 years, 8 months ago (2014-04-02 19:41:25 UTC) #2
ykyyip
The CQ bit was checked by ykyyip@chromium.org
6 years, 8 months ago (2014-04-02 19:42:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ykyyip@chromium.org/222473004/1
6 years, 8 months ago (2014-04-02 19:42:41 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 20:50:35 UTC) #5
Message was sent while issue was closed.
Change committed as 170700

Powered by Google App Engine
This is Rietveld 408576698