Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 222473004: Fix scrolling fixed objs containing abs pos obj (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1717 matching lines...) Expand 10 before | Expand all | Expand 10 after
1728 1728
1729 // Don't need to do this for composited fixed items. 1729 // Don't need to do this for composited fixed items.
1730 if (layer->compositingState() == PaintsIntoOwnBacking) 1730 if (layer->compositingState() == PaintsIntoOwnBacking)
1731 continue; 1731 continue;
1732 1732
1733 // Also don't need to do this for invisible items. 1733 // Also don't need to do this for invisible items.
1734 if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotC ompositedForBoundsOutOfView 1734 if (layer->viewportConstrainedNotCompositedReason() == RenderLayer::NotC ompositedForBoundsOutOfView
1735 || layer->viewportConstrainedNotCompositedReason() == RenderLayer::N otCompositedForNoVisibleContent) 1735 || layer->viewportConstrainedNotCompositedReason() == RenderLayer::N otCompositedForNoVisibleContent)
1736 continue; 1736 continue;
1737 1737
1738 layer->repainter().computeRepaintRects(renderer->containerForRepaint()); 1738 layer->repainter().computeRepaintRectsIncludingDescendants();
1739 } 1739 }
1740 } 1740 }
1741 1741
1742 bool FrameView::shouldRubberBandInDirection(ScrollDirection direction) const 1742 bool FrameView::shouldRubberBandInDirection(ScrollDirection direction) const
1743 { 1743 {
1744 Page* page = frame().page(); 1744 Page* page = frame().page();
1745 if (!page) 1745 if (!page)
1746 return ScrollView::shouldRubberBandInDirection(direction); 1746 return ScrollView::shouldRubberBandInDirection(direction);
1747 return page->chrome().client().shouldRubberBandInDirection(direction); 1747 return page->chrome().client().shouldRubberBandInDirection(direction);
1748 } 1748 }
(...skipping 1517 matching lines...) Expand 10 before | Expand all | Expand 10 after
3266 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3266 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3267 { 3267 {
3268 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3268 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3269 if (AXObjectCache* cache = axObjectCache()) { 3269 if (AXObjectCache* cache = axObjectCache()) {
3270 cache->remove(scrollbar); 3270 cache->remove(scrollbar);
3271 cache->handleScrollbarUpdate(this); 3271 cache->handleScrollbarUpdate(this);
3272 } 3272 }
3273 } 3273 }
3274 3274
3275 } // namespace WebCore 3275 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698