mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

ShelfGestureHandler uses aura windows and is a dependency of ShelfView.
We're moving ShelfView to wm common types.

* Fold ShelfGestureHandler into ShelfLayoutManager.
* Eliminate the event_target_window parameter from ProcessGestureEvent because
the shelf can look up its own root window.
* Eliminate unused ui::ET_GESTURE_WIN8_EDGE_SWIPE which existed to support
these gestures.

BUG=629252, 635130
TEST=ash_unittests, manual tests of shelf gesture show/hide behavior

Committed: https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6
Cr-Commit-Position: refs/heads/master@{#410416}

[James Cook, 2016-08-05 23:06:11]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-05 23:24:26]

Description was changed from

==========
mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

ShelfGestureHandler uses aura windows and is a dependency of ShelfView.
We're moving ShelfView to wm common types.

* Fold ShelfGestureHandler into ShelfLayoutManager.
* Eliminate unused ui::ET_GESTURE_WIN8_EDGE_SWIPE which existed to support
some of these gestures.

BUG=629252,635130
TEST=ash_unittests, manual tests of shelf gesture show/hide behavior
==========

to

==========
mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

ShelfGestureHandler uses aura windows and is a dependency of ShelfView.
We're moving ShelfView to wm common types.

* Fold ShelfGestureHandler into ShelfLayoutManager.
* Eliminate the event_target_window parameter from ProcessGestureEvent because
the shelf can look up its own root window.
* Eliminate unused ui::ET_GESTURE_WIN8_EDGE_SWIPE which existed to support
these gestures.

BUG=629252,635130
TEST=ash_unittests, manual tests of shelf gesture show/hide behavior
==========

[James Cook, 2016-08-05 23:25:17]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-05 23:27:06]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-05 23:27:07]

msw, please take a look.

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:1129: void
ShelfLayoutManager::StartGestureDrag(const ui::GestureEvent& gesture) {
These methods are moved unchanged in order to match the header order.

[msw, 2016-08-05 23:48:49]

lgtm with minor comment nits (feel free to ignore)

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:370: if (ProcessGestureEvent(*event))
optional nit: combine nested conditional with the outer one.

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:1129: void
ShelfLayoutManager::StartGestureDrag(const ui::GestureEvent& gesture) {
On 2016/08/05 23:27:07, James Cook wrote:
> These methods are moved unchanged in order to match the header order.

Acknowledged.

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:123: // appropriate. Returns true of the
gesture has been handled and it should not
nit: s/of/if/

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:124: // be processed any farther, false
otherwise.
nit: s/farther/further/

[James Cook, 2016-08-05 23:55:07]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-05 23:55:17]

Thanks!

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:370: if (ProcessGestureEvent(*event))
On 2016/08/05 23:48:49, msw wrote:
> optional nit: combine nested conditional with the outer one.

Done.

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.h (right):

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:123: // appropriate. Returns true of the
gesture has been handled and it should not
On 2016/08/05 23:48:49, msw wrote:
> nit: s/of/if/

Doh. Done.

https://codereview.chromium.org/2224653002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.h:124: // be processed any farther, false
otherwise.
On 2016/08/05 23:48:49, msw wrote:
> nit: s/farther/further/

Done.

[commit-bot: I haz the power, 2016-08-05 23:55:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-05 23:55:43]

jamescook@chromium.org changed reviewers:
+ sadrul@chromium.org

[James Cook, 2016-08-05 23:55:43]

sadrul, can I get OWNERS for deleting some unused code in //ui/events ?

[sadrul, 2016-08-06 00:02:00]

lgtm. Thanks for cleaning this up!

[commit-bot: I haz the power, 2016-08-06 00:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:29:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[James Cook, 2016-08-08 17:39:52]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-08 17:39:53]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2224653002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-08 17:40:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:11:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-08 20:13:22]

Description was changed from

==========
mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

ShelfGestureHandler uses aura windows and is a dependency of ShelfView.
We're moving ShelfView to wm common types.

* Fold ShelfGestureHandler into ShelfLayoutManager.
* Eliminate the event_target_window parameter from ProcessGestureEvent because
the shelf can look up its own root window.
* Eliminate unused ui::ET_GESTURE_WIN8_EDGE_SWIPE which existed to support
these gestures.

BUG=629252,635130
TEST=ash_unittests, manual tests of shelf gesture show/hide behavior
==========

to

==========
mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

ShelfGestureHandler uses aura windows and is a dependency of ShelfView.
We're moving ShelfView to wm common types.

* Fold ShelfGestureHandler into ShelfLayoutManager.
* Eliminate the event_target_window parameter from ProcessGestureEvent because
the shelf can look up its own root window.
* Eliminate unused ui::ET_GESTURE_WIN8_EDGE_SWIPE which existed to support
these gestures.

BUG=629252,635130
TEST=ash_unittests, manual tests of shelf gesture show/hide behavior

Committed: https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6
Cr-Commit-Position: refs/heads/master@{#410416}
==========

[commit-bot: I haz the power, 2016-08-08 20:13:23]

Patchset 5 (id:??) landed as
https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6
Cr-Commit-Position: refs/heads/master@{#410416}