Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2224583004:
Explicitly list content of generated .dSYM directory. (Closed)
DescriptionExplicitly list content of generated .dSYM directory.
Chrome on iOS wants to use the content of .dSYM directory generated
when enable_dsyms is set to true, so explicitly list the files that
are found inside.
Change some deps to public deps so that the .dSYM files are visible
via a public dependency when depending on the create_bundle target.
BUG=634777
Committed: https://crrev.com/8d79e46082552107fdcd2016fd08c0fd5795fd48
Cr-Commit-Position: refs/heads/master@{#410486}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Convert dsym_output variable to a list to avoid repetition. #
Dependent Patchsets: Messages
Total messages: 28 (19 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org, rsesek@chromium.org
Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
olivierrobin@chromium.org changed reviewers: + olivierrobin@chromium.org
lgtm
https://codereview.chromium.org/2224583004/diff/40001/build/toolchain/mac/BUI... File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/2224583004/diff/40001/build/toolchain/mac/BUI... build/toolchain/mac/BUILD.gn:117: _dsym_output = Why not just make this a list too?
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
PTAL https://codereview.chromium.org/2224583004/diff/40001/build/toolchain/mac/BUI... File build/toolchain/mac/BUILD.gn (right): https://codereview.chromium.org/2224583004/diff/40001/build/toolchain/mac/BUI... build/toolchain/mac/BUILD.gn:117: _dsym_output = On 2016/08/08 19:13:04, Robert Sesek wrote: > Why not just make this a list too? I didn't think of turning this into a list. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from olivierrobin@chromium.org Link to the patchset: https://codereview.chromium.org/2224583004/#ps60001 (title: "Convert dsym_output variable to a list to avoid repetition.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Explicitly list content of generated .dSYM directory. Chrome on iOS wants to use the content of .dSYM directory generated when enable_dsyms is set to true, so explicitly list the files that are found inside. Change some deps to public deps so that the .dSYM files are visible via a public dependency when depending on the create_bundle target. BUG=634777 ========== to ========== Explicitly list content of generated .dSYM directory. Chrome on iOS wants to use the content of .dSYM directory generated when enable_dsyms is set to true, so explicitly list the files that are found inside. Change some deps to public deps so that the .dSYM files are visible via a public dependency when depending on the create_bundle target. BUG=634777 Committed: https://crrev.com/8d79e46082552107fdcd2016fd08c0fd5795fd48 Cr-Commit-Position: refs/heads/master@{#410486} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8d79e46082552107fdcd2016fd08c0fd5795fd48 Cr-Commit-Position: refs/heads/master@{#410486}
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
