Revert "Clear isolate callback data before running shutdowncallback"

Currently breaks Dartium.  Will investigate with John.

Revert "Clear isolate callback data before running shutdowncallback"

This reverts commit aed6dd844d3f49acf97294e45d0ec9cfeaf6f508.

TBR=jacobr@google.com,johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/c811e3c26e9fdf6ff35f19c56d2d12ccf3d818df

[terry, 2016-08-05 18:00:24]

Description was changed from

==========
Revert "Clear isolate callback data before running shutdowncallback"

This reverts commit aed6dd844d3f49acf97294e45d0ec9cfeaf6f508.

TBR=jacobr@google.com,johnmccutchan@google.com
==========

to

==========
Currently breaks Dartium.  Will investigate with John.

Revert "Clear isolate callback data before running shutdowncallback"

This reverts commit aed6dd844d3f49acf97294e45d0ec9cfeaf6f508.

TBR=jacobr@google.com,johnmccutchan@google.com
==========

[terry, 2016-08-05 18:01:59]

Description was changed from

==========
Currently breaks Dartium.  Will investigate with John.

Revert "Clear isolate callback data before running shutdowncallback"

This reverts commit aed6dd844d3f49acf97294e45d0ec9cfeaf6f508.

TBR=jacobr@google.com,johnmccutchan@google.com
==========

to

==========
Currently breaks Dartium.  Will investigate with John.

Revert "Clear isolate callback data before running shutdowncallback"

This reverts commit aed6dd844d3f49acf97294e45d0ec9cfeaf6f508.

TBR=jacobr@google.com,johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c811e3c26e9fdf6ff35f19c56d2d12ccf3d818df
==========

[terry, 2016-08-05 18:02:00]

Committed patchset #1 (id:1) manually as
c811e3c26e9fdf6ff35f19c56d2d12ccf3d818df (presubmit successful).

[Jacob, 2016-08-05 18:10:15]

lgtm

[siva, 2016-08-05 20:50:20]

asiva@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-08-05 20:50:20]

Terry,

Can we figure out why Dartium is crashing with this fix because we clearly have
a race here with the isolate callback
data not being cleared when the isolate is shutting down.

Reverting the change exposes a crash that we are seeing elsewhere. It would be
nice to know why dartium is failing. As far as we know dartium does not register
a shutdown callback so it is not clear why that would effect this,

It could be some code that accesses DartDOMData::Current() without checking if
it returns NULL. I see some cases like that in DartUtilities::stringToDart