runtime/vm/dart.cc - Issue 2224543002: Revert "Clear isolate callback data before running shutdowncallback"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart.cc

Issue 2224543002: Revert "Clear isolate callback data before running shutdowncallback" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart.cc

diff --git a/runtime/vm/dart.cc b/runtime/vm/dart.cc

index 9c4ac8359bb3345f2eb84014bafdd81865a20486..0bd87305473461b7073aafd2b39fd238851b100f 100644

--- a/runtime/vm/dart.cc

+++ b/runtime/vm/dart.cc

@@ -669,8 +669,6 @@ const char* Dart::FeaturesString(Snapshot::Kind kind) {

void Dart::RunShutdownCallback() {

Isolate* isolate = Isolate::Current();

void* callback_data = isolate->init_callback_data();

- // Clear the data from the isolate so future accesses will see NULL.

- isolate->set_init_callback_data(NULL);

Dart_IsolateShutdownCallback callback = Isolate::ShutdownCallback();

if (callback != NULL) {

(callback)(callback_data);

« no previous file with comments | « no previous file | no next file » | no next file with comments »