Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2224333002: [modules] Split imports into regular and special, store regular ones in a map. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Split imports into regular and special, store regular ones in a map. BUG=v8:1569 Committed: https://crrev.com/29e85e36f363203e3e1735c648b0f78837d57343 Cr-Commit-Position: refs/heads/master@{#38532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -16 lines) Patch
M src/ast/modules.h View 3 chunks +16 lines, -5 lines 0 comments Download
M src/ast/modules.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +122 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
neis
ptal
4 years, 4 months ago (2016-08-09 15:08:23 UTC) #6
adamk
lgtm I don't love the names "special" or "regular", but there's not enough code yet ...
4 years, 4 months ago (2016-08-09 16:47:48 UTC) #7
adamk
Also, I added the modules tracking bug, I think it'd be good to attach that ...
4 years, 4 months ago (2016-08-09 16:48:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224333002/1
4 years, 4 months ago (2016-08-10 11:40:29 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 11:42:04 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29e85e36f363203e3e1735c648b0f78837d57343 Cr-Commit-Position: refs/heads/master@{#38532}
4 years, 4 months ago (2016-08-10 11:42:24 UTC) #15
neis
4 years, 4 months ago (2016-08-10 11:43:02 UTC) #16
Message was sent while issue was closed.
On 2016/08/09 16:47:48, adamk wrote:
> lgtm
> 
> I don't love the names "special" or "regular", but there's not enough code yet
> for me to think of better ones for now :)

I'm not very happy with them either.

Powered by Google App Engine
This is Rietveld 408576698