Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2223893004: [modules] Detect all indirect exports and represent them as such. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@modules-imports
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Detect all indirect exports and represent them as such. BUG=v8:1569 Committed: https://crrev.com/b2ff10c43d0b0c13dc27dbd3f67ac94d8d8beb38 Cr-Commit-Position: refs/heads/master@{#38538}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Move call into Validate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -120 lines) Patch
M src/ast/modules.h View 1 3 chunks +22 lines, -4 lines 0 comments Download
M src/ast/modules.cc View 1 2 chunks +19 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +74 lines, -115 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
neis
ptal
4 years, 4 months ago (2016-08-09 15:08:55 UTC) #5
adamk
https://codereview.chromium.org/2223893004/diff/1/src/ast/modules.h File src/ast/modules.h (right): https://codereview.chromium.org/2223893004/diff/1/src/ast/modules.h#newcode103 src/ast/modules.h:103: const ZoneList<ModuleEntry*>& exports() const { return exports_; } Maybe ...
4 years, 4 months ago (2016-08-09 16:52:52 UTC) #9
adamk
lgtm with nits, don't want this to be held up on my review
4 years, 4 months ago (2016-08-09 17:42:22 UTC) #10
neis
https://codereview.chromium.org/2223893004/diff/1/src/ast/modules.h File src/ast/modules.h (right): https://codereview.chromium.org/2223893004/diff/1/src/ast/modules.h#newcode103 src/ast/modules.h:103: const ZoneList<ModuleEntry*>& exports() const { return exports_; } On ...
4 years, 4 months ago (2016-08-10 11:53:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223893004/20001
4 years, 4 months ago (2016-08-10 11:53:47 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 12:18:20 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b2ff10c43d0b0c13dc27dbd3f67ac94d8d8beb38 Cr-Commit-Position: refs/heads/master@{#38538}
4 years, 4 months ago (2016-08-10 12:18:35 UTC) #18
adamk
4 years, 4 months ago (2016-08-10 17:30:29 UTC) #19
Message was sent while issue was closed.
https://codereview.chromium.org/2223893004/diff/1/src/ast/modules.h
File src/ast/modules.h (right):

https://codereview.chromium.org/2223893004/diff/1/src/ast/modules.h#newcode103
src/ast/modules.h:103: const ZoneList<ModuleEntry*>& exports() const { return
exports_; }
On 2016/08/10 11:53:30, neis wrote:
> On 2016/08/09 16:52:51, adamk wrote:
> > Maybe remove the const-ness of this method? I realize it's still C++-const,
> but
> > it's no longer conceptually-const.
> 
> I don't understand, it's just a getter.

But it now lets callers mutate the internal state of the class (the ModuleEntry
objects).

Anyway, this really doesn't matter too much, just one of those C++ things that's
easy to have different opinions on.

Powered by Google App Engine
This is Rietveld 408576698