Issue 222433002: ARM64: Introduce a version of ADR handling distant targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222433002: ARM64: Introduce a version of ADR handling distant targets. (Closed)

Created:
6 years, 8 months ago by Alexandre Rames

Modified:
6 years, 8 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM64: Introduce a version of ADR handling distant targets. This fixes an out-of-range label error for an ADR instruction in the mozilla/data/js1_5/Regress/regress-280769-2.js test. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20545

Patch Set 1 #

Patch Set 2 : Fix loop offset #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -15 lines)			Patch
M	src/arm64/assembler-arm64.h	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	src/arm64/assembler-arm64.cc	View	1	1 chunk	+70 lines, -0 lines	0 comments	Download
M	src/arm64/instructions-arm64.h	View		4 chunks	+14 lines, -1 line	0 comments	Download
M	src/arm64/instructions-arm64.cc	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.h	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	src/arm64/macro-assembler-arm64.cc	View		1 chunk	+37 lines, -0 lines	1 comment	Download
M	src/arm64/macro-assembler-arm64-inl.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/arm64/regexp-macro-assembler-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-assembler-arm64.cc	View		1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/222433002/diff/20001/src/arm64/macro-assembler-arm64.cc File src/arm64/macro-assembler-arm64.cc (right): https://codereview.chromium.org/222433002/diff/20001/src/arm64/macro-assembler-arm64.cc#newcode622 src/arm64/macro-assembler-arm64.cc:622: int min_adr_offset = -1 << (Instruction::ImmPCRelRangeBitwidth - 1); ...

6 years, 8 months ago (2014-04-07 11:54:15 UTC) #2

Alexandre Rames

6 years, 8 months ago (2014-04-07 12:33:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20545 (presubmit successful).

Expand Messages | Collapse Messages