Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2224263003: Include non-composited layout views in existing workaround for clipping changes. (Closed)

Created:
4 years, 4 months ago by wkorman
Modified:
4 years, 4 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, foolip, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include non-composited layout views in existing workaround for clipping changes. Reland of http://crrev.com/2212403004 reverted in http://crrev.com/2220423004. Test failures leading to the revert were determined to be unrelated to this change. BUG=635892, 635892 TBR=chrishtr Committed: https://crrev.com/f4f6b5170078b6312f775e86ca90dc295b3db956 Cr-Commit-Position: refs/heads/master@{#410893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/resize-iframe-text.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/repaint/resources/resize-iframe-text-src.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
wkorman
4 years, 4 months ago (2016-08-09 18:35:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224263003/1
4 years, 4 months ago (2016-08-09 18:35:29 UTC) #3
chrishtr
lgtm
4 years, 4 months ago (2016-08-09 18:35:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/118988)
4 years, 4 months ago (2016-08-09 20:20:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224263003/1
4 years, 4 months ago (2016-08-09 20:22:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/270241)
4 years, 4 months ago (2016-08-09 22:41:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224263003/1
4 years, 4 months ago (2016-08-09 22:46:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 00:22:00 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 00:23:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4f6b5170078b6312f775e86ca90dc295b3db956
Cr-Commit-Position: refs/heads/master@{#410893}

Powered by Google App Engine
This is Rietveld 408576698