Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2224263003: Include non-composited layout views in existing workaround for clipping changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/resources/resize-iframe-text-src.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 400
401 // TODO(wangxianzhu): This is a workaround for crbug.com/533277. Will remove when we enable paint offset caching. 401 // TODO(wangxianzhu): This is a workaround for crbug.com/533277. Will remove when we enable paint offset caching.
402 if (reason != PaintInvalidationNone && hasPercentageTransform(styleRef())) 402 if (reason != PaintInvalidationNone && hasPercentageTransform(styleRef()))
403 newPaintInvalidationState.setForceSubtreeInvalidationCheckingWithinConta iner(); 403 newPaintInvalidationState.setForceSubtreeInvalidationCheckingWithinConta iner();
404 404
405 // TODO(wangxianzhu): This is a workaround for crbug.com/490725. We don't ha ve enough saved information to do accurate check 405 // TODO(wangxianzhu): This is a workaround for crbug.com/490725. We don't ha ve enough saved information to do accurate check
406 // of clipping change. Will remove when we remove rect-based paint invalidat ion. 406 // of clipping change. Will remove when we remove rect-based paint invalidat ion.
407 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() 407 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()
408 && previousPaintInvalidationRect != this->previousPaintInvalidationRect( ) 408 && previousPaintInvalidationRect != this->previousPaintInvalidationRect( )
409 && !usesCompositedScrolling() 409 && !usesCompositedScrolling()
410 && hasOverflowClip()) 410 // Note that isLayoutView() below becomes unnecessary after the launch o f root layer scrolling.
411 && (hasOverflowClip() || isLayoutView()))
411 newPaintInvalidationState.setForceSubtreeInvalidationRectUpdateWithinCon tainer(); 412 newPaintInvalidationState.setForceSubtreeInvalidationRectUpdateWithinCon tainer();
412 413
413 newPaintInvalidationState.updateForChildren(reason); 414 newPaintInvalidationState.updateForChildren(reason);
414 invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState); 415 invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);
415 } 416 }
416 417
417 void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe ct& r, PaintInvalidationReason invalidationReason, const LayoutObject& object) c onst 418 void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe ct& r, PaintInvalidationReason invalidationReason, const LayoutObject& object) c onst
418 { 419 {
419 // TODO(wangxianzhu): Enable the following assert after paint invalidation f or spv2 is ready. 420 // TODO(wangxianzhu): Enable the following assert after paint invalidation f or spv2 is ready.
420 // ASSERT(!RuntimeEnabledFeatures::slimmingPaintV2Enabled()); 421 // ASSERT(!RuntimeEnabledFeatures::slimmingPaintV2Enabled());
(...skipping 707 matching lines...) Expand 10 before | Expand all | Expand 10 after
1128 if (rootElementStyle->hasBackground()) 1129 if (rootElementStyle->hasBackground())
1129 return false; 1130 return false;
1130 1131
1131 if (node() != document().firstBodyElement()) 1132 if (node() != document().firstBodyElement())
1132 return false; 1133 return false;
1133 1134
1134 return true; 1135 return true;
1135 } 1136 }
1136 1137
1137 } // namespace blink 1138 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/resources/resize-iframe-text-src.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698