content/browser/frame_host/navigation_entry_impl.h - Issue 2224213005: Ensure FrameNavigationEntry is fully updated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2224213005: Ensure FrameNavigationEntry is fully updated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clear children FNEs of main frame on redirects. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl.h

diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h

index e76f391ad6cceff250cf72f4c7f2e3ccc6d2675b..04162896b4793be53730fc0817eeb24e33b95314 100644

--- a/content/browser/frame_host/navigation_entry_impl.h

+++ b/content/browser/frame_host/navigation_entry_impl.h

@@ -227,11 +227,6 @@ class CONTENT_EXPORT NavigationEntryImpl

// there is one in this NavigationEntry.

FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const;

- // Removes subframe FrameNavigationEntries below the item corresponding to

- // |frame_tree_node| (if any). This is necessary after server redirects

- // during session history navigations, when the child items no longer apply.

- void ClearChildren(FrameTreeNode* frame_tree_node);

Charlie Reis 2016/08/10 17:03:09 Great! Thanks for removing this.

nasko 2016/08/10 18:08:51 No problem! I like removing code :)

// Removes any subframe FrameNavigationEntries that match the unique name of

// |frame_tree_node|, and all of their children. There should be at most one,

// since collisions are avoided but leave old FrameNavigationEntries in the