Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 2224213005: Ensure FrameNavigationEntry is fully updated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clear children FNEs of main frame on redirects. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 const GURL& url, 220 const GURL& url,
221 const Referrer& referrer, 221 const Referrer& referrer,
222 const PageState& page_state, 222 const PageState& page_state,
223 const std::string& method, 223 const std::string& method,
224 int64_t post_id); 224 int64_t post_id);
225 225
226 // Returns the FrameNavigationEntry corresponding to |frame_tree_node|, if 226 // Returns the FrameNavigationEntry corresponding to |frame_tree_node|, if
227 // there is one in this NavigationEntry. 227 // there is one in this NavigationEntry.
228 FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const; 228 FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const;
229 229
230 // Removes subframe FrameNavigationEntries below the item corresponding to
231 // |frame_tree_node| (if any). This is necessary after server redirects
232 // during session history navigations, when the child items no longer apply.
233 void ClearChildren(FrameTreeNode* frame_tree_node);
Charlie Reis 2016/08/10 17:03:09 Great! Thanks for removing this.
nasko 2016/08/10 18:08:51 No problem! I like removing code :)
234
235 // Removes any subframe FrameNavigationEntries that match the unique name of 230 // Removes any subframe FrameNavigationEntries that match the unique name of
236 // |frame_tree_node|, and all of their children. There should be at most one, 231 // |frame_tree_node|, and all of their children. There should be at most one,
237 // since collisions are avoided but leave old FrameNavigationEntries in the 232 // since collisions are avoided but leave old FrameNavigationEntries in the
238 // tree after their frame has been detached. 233 // tree after their frame has been detached.
239 void ClearStaleFrameEntriesForNewFrame(FrameTreeNode* frame_tree_node); 234 void ClearStaleFrameEntriesForNewFrame(FrameTreeNode* frame_tree_node);
240 235
241 void set_unique_id(int unique_id) { 236 void set_unique_id(int unique_id) {
242 unique_id_ = unique_id; 237 unique_id_ = unique_id;
243 } 238 }
244 239
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
527 // persisted, unless specific data is taken out/put back in at save/restore 522 // persisted, unless specific data is taken out/put back in at save/restore
528 // time (see TabNavigation for an example of this). 523 // time (see TabNavigation for an example of this).
529 std::map<std::string, base::string16> extra_data_; 524 std::map<std::string, base::string16> extra_data_;
530 525
531 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl); 526 DISALLOW_COPY_AND_ASSIGN(NavigationEntryImpl);
532 }; 527 };
533 528
534 } // namespace content 529 } // namespace content
535 530
536 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_ 531 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_ENTRY_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698