Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2224193002: [Offline pages] Add ntp suggestions as a new namespace (Closed)

Created:
4 years, 4 months ago by chili
Modified:
4 years, 4 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Add ntp suggestions as a new namespace BUG=635648 Committed: https://crrev.com/0bc573f574ebb1bf8d8619a13364f60cf7b4a0cd Cr-Commit-Position: refs/heads/master@{#410831}

Patch Set 1 #

Patch Set 2 : Correct parens and rebase-update #

Patch Set 3 : Fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M components/offline_pages/client_namespace_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/client_namespace_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/client_policy_controller.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M components/offline_pages/client_policy_controller_unittest.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
chili
4 years, 4 months ago (2016-08-08 23:04:37 UTC) #2
Pete Williamson
lgtm
4 years, 4 months ago (2016-08-08 23:17:03 UTC) #3
Dmitry Titov
lgtm
4 years, 4 months ago (2016-08-09 00:23:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224193002/1
4 years, 4 months ago (2016-08-09 00:26:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/203853) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 00:32:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224193002/1
4 years, 4 months ago (2016-08-09 03:00:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/48406)
4 years, 4 months ago (2016-08-09 03:06:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224193002/20001
4 years, 4 months ago (2016-08-09 17:48:49 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/48825)
4 years, 4 months ago (2016-08-09 17:54:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224193002/40001
4 years, 4 months ago (2016-08-09 18:22:26 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/234065)
4 years, 4 months ago (2016-08-09 18:29:22 UTC) #22
chili
+holte for histogram
4 years, 4 months ago (2016-08-09 18:33:09 UTC) #24
Steven Holte
lgtm
4 years, 4 months ago (2016-08-09 19:20:51 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224193002/40001
4 years, 4 months ago (2016-08-09 20:52:49 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 21:35:51 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 21:39:19 UTC) #31
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0bc573f574ebb1bf8d8619a13364f60cf7b4a0cd
Cr-Commit-Position: refs/heads/master@{#410831}

Powered by Google App Engine
This is Rietveld 408576698