Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2224193002: [Offline pages] Add ntp suggestions as a new namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_model_impl_unittest.cc b/components/offline_pages/offline_page_model_impl_unittest.cc
index eb6c721615552459e7054861ce4c6473acdf799f..b8d70c13349de98831458a2addf5d0e8b71773af 100644
--- a/components/offline_pages/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/offline_page_model_impl_unittest.cc
@@ -1078,6 +1078,15 @@ TEST_F(OfflinePageModelImplTest, DownloadNamespace) {
static_cast<int>(SavePageResult::SUCCESS), 1);
}
+TEST_F(OfflinePageModelImplTest, NewTabPageNamespace) {
+ SavePage(kTestUrl, ClientId(kNTPSuggestionsNamespace, "123"));
+ std::string histogram_name = "OfflinePages.SavePageResult.";
+ histogram_name += kNTPSuggestionsNamespace;
+
+ histograms().ExpectUniqueSample(histogram_name,
+ static_cast<int>(SavePageResult::SUCCESS), 1);
+}
+
TEST(CommandLineFlagsTest, OfflineBookmarks) {
// Disabled by default.
EXPECT_FALSE(offline_pages::IsOfflineBookmarksEnabled());
« no previous file with comments | « components/offline_pages/client_policy_controller_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698