Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2224173005: Revert of DevTools: do not use string templates in front-end, minifier is confused. (Closed)

Created:
4 years, 4 months ago by paulirish
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: do not use string templates in front-end, minifier is confused. (patchset #1 id:1 of https://codereview.chromium.org/2226163002/ ) Reason for revert: https://codereview.chromium.org/2229683002 landed so we don't need this any longer Original issue's description: > DevTools: do not use string templates in front-end, minifier is confused. > > R=paulirish > BUG=623983 > > Committed: https://crrev.com/79df4803990d12f67cbaba6d912673d163baac12 > Cr-Commit-Position: refs/heads/master@{#410842} TBR=pfeldman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623983 Committed: https://crrev.com/f4791481181df61d43d75188bf095375a1641401 Cr-Commit-Position: refs/heads/master@{#411208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
paulirish
Created Revert of DevTools: do not use string templates in front-end, minifier is confused.
4 years, 4 months ago (2016-08-09 22:46:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224173005/1
4 years, 4 months ago (2016-08-09 22:46:55 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-09 22:46:56 UTC) #5
pfeldman
lgtm
4 years, 4 months ago (2016-08-11 00:50:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2224173005/1
4 years, 4 months ago (2016-08-11 00:51:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 00:52:05 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 00:53:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4791481181df61d43d75188bf095375a1641401
Cr-Commit-Position: refs/heads/master@{#411208}

Powered by Google App Engine
This is Rietveld 408576698